New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of flexbox #579

merged 64 commits into from Mar 7, 2018


None yet
1 participant

liZe commented Feb 24, 2018

Fix #324, thanks to Lucien!

This PR doesn't provide a perfect support of flexbox, but it shouldn't introduce any regressions and doesn't crash with any of the W3C suite tests. And it's not that bad with real-life cases 😉.

What's not supported yet:

  • floats (inside or outside the flex container),
  • position of some absolutely-positioned flex children,
  • forced and avoided page breaks in flex container and flex items,
  • some alignments of flex items with margins,
  • table and table-* flex items,
  • many page breaks in flex containers (especially with reordered flex items),
  • many min-width, max-width, min-height and max-height values of flex items,
  • shrink-to-fit size of flex containers,
  • collapsed items…

Many TODOs are in and could be quite easily fixed following the spec.

I'll fix some easy-to-fix problems before merging this PR, using the W3C tests and some real case uses. I'll need to add tests in WP too.

lucien and others added some commits Dec 7, 2017

liZe added some commits Feb 21, 2018

Use block_container_layout for final flex items layout
block_level_layout is not needed as width and height have already been fixed
during flex layout.
Handle column layout in block_box_layout
This change gives flex_layout a chance to use block_box_layout, that can handle
more cases (including columns) than block_container_layout witout resetting
size set by flex layout.

This comment has been minimized.


liZe commented Mar 7, 2018

Time to merge. We have almost 50% of the W3C test suite passing, with a lot of tests relying on Regions or Grid, and some old tests based on old properties that have been removed. There's no crash with the test suite and hopefully no regressions.

Page breaks and floats for example could be highly improved, but fixes can be added on master.

@liZe liZe merged commit 806d3d5 into master Mar 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@liZe liZe deleted the flexbox branch Mar 7, 2018

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Nov 14, 2018

py-weasyprint: Update to 43.
Version 43

Released on 2018-11-09.

Bug fixes:

* `#726 <>`_:
  Make empty strings clear previous values of named strings
* `#729 <>`_:
  Include tools in packaging

This version also includes the changes from unstable rc1 and rc2 versions
listed below.

Version 43rc2

Released on 2018-11-02.

**This version is experimental, don't use it in production. If you find bugs,
please report them!**

Bug fixes:

* `#706 <>`_:
  Fix text-indent at the beginning of a page
* `#687 <>`_:
  Allow query strings in file:// URIs
* `#720 <>`_:
  Optimize minimum size calculation of long inline elements
* `#717 <>`_:
  Display <details> tags as blocks
* `#691 <>`_:
  Don't recalculate max content widths when distributing extra space for tables
* `#722 <>`_:
  Fix bookmarks and strings set on images
* `#723 <>`_:
  Warn users when string() is not used in page margin

Version 43rc1

Released on 2018-10-15.

**This version is experimental, don't use it in production. If you find bugs,
please report them!**


* Python 3.4+ is now needed, Python 2.x is not supported anymore
* Cairo 1.15.4+ is now needed, but 1.10+ should work with missing features
  (such as links, outlines and metadata)
* Pdfrw is not needed anymore

New features:

* `Beautiful website <>`_
* `#579 <>`_:
  Initial support of flexbox
* `#592 <>`_:
  Support @font-face on Windows
* `#306 <>`_:
  Add a timeout parameter to the URL fetcher functions
* `#594 <>`_:
  Split tests using modern pytest features
* `#599 <>`_:
  Make tests pass on Windows
* `#604 <>`_:
  Handle target counters and target texts
* `#631 <>`_:
  Enable counter-increment and counter-reset in page context
* `#622 <>`_:
  Allow pathlib.Path objects for HTML, CSS and Attachment classes
* `#674 <>`_:
  Add extensive installation instructions for Windows

Bug fixes:

* `#558 <>`_:
  Fix attachments
* `#565 <>`_,
  `#596 <>`_,
  `#539 <>`_:
  Fix many PDF rendering, printing and compatibility problems
* `#614 <>`_:
  Avoid crashes and endless loops caused by a Pango bug
* `#662 <>`_:
  Fix warnings and errors when generating documentation
* `#666 <>`_,
  `#685 <>`_:
  Fix many table layout rendering problems
* `#680 <>`_:
  Don't crash when there's no font available
* `#662 <>`_:
  Fix support of some align values in tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment