Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of standard print media sizes #805

Closed
wants to merge 2 commits into from

Conversation

rmackinnon
Copy link

css/computed_valued.py: Added dimensions for output to defined common book sizes (mass market paperback/novella/digest/us_tradeback, textbook small/medium/fullsize).

@rmackinnon
Copy link
Author

Looks like the build is failing on python 3.6 tests with the cairocffi version, but all the other versions pass.

@liZe
Copy link
Member

liZe commented Feb 17, 2019

Hello @rmackinnon,

Thanks a lot for taking the time to create a pull request!

WeasyPrint tries to blindly follow the specifications, and unfortunately these book sizes are not included in https://drafts.csswg.org/css-page-3/#typedef-page-size-page-size, and not even in IEEE ISTO Printer Working Group's reference document.

I know that this PR may look harmless (and they always are … at the beginning 😄), but each time I've tried to include this kind of changes, I've met problems afterwards. So please forgive me for being the bad guy, but … I'll be the bad guy. I hope you won't be mad at me, but as it's not a blocking problem it shouldn't prevent you from using WeasyPrint 🙏.

@liZe liZe closed this Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants