Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink min-max-height and -width according to box-sizing #823

Merged
merged 1 commit into from Mar 14, 2019

Conversation

2 participants
@Tontyna
Copy link
Contributor

commented Mar 13, 2019

Since not only box.width and box.height designate content dimensions, but also min-width and max-width, min-height and max-height, all 6 values must be shrinked if box-sizing isn't content-box.

Should fix #820

As always: Parsed some htmls to prove the issue is fixed, but didnt bother to write a unit-test 馃槒

@liZe Is there a reason to not prevent reduced box.width and box.height from being negative?

@liZe liZe merged commit 3c8af49 into Kozea:master Mar 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@liZe

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

Thank you.

As always: Parsed some htmls to prove the issue is fixed, but didnt bother to write a unit-test

No problem.

Is there a reason to not prevent reduced box.width and box.height from being negative?

Not really.

@liZe liZe added this to the 46 milestone Mar 18, 2019

@liZe

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

Tests have been added in fc089f5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.