Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named strings and counter names are case sensitive #827

Merged
merged 3 commits into from Mar 18, 2019

Conversation

2 participants
@Tontyna
Copy link
Contributor

Tontyna commented Mar 16, 2019

Should close #826

BTW: The case-sensitivity of counter names is buggy, too.

Tontyna added some commits Mar 16, 2019

@Tontyna Tontyna changed the title Named strings are case sensitive Named strings and counter names are case sensitive Mar 16, 2019

@liZe

This comment has been minimized.

Copy link
Member

liZe commented Mar 18, 2019

Thank you.

BTW: The case-sensitivity of counter names is buggy, too.

I'll check that.

@liZe liZe merged commit b6b8257 into Kozea:master Mar 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@liZe liZe added this to the 46 milestone Mar 18, 2019

@Tontyna

This comment has been minimized.

Copy link
Contributor Author

Tontyna commented Mar 18, 2019

Addendum: The case-sensitivity of counter names is was buggy, too.
Should be fixed by the 2nd and 3rd commit of this PR

@Tontyna Tontyna deleted the Tontyna:string-set-case branch Mar 18, 2019

@Tontyna

This comment has been minimized.

Copy link
Contributor Author

Tontyna commented Mar 18, 2019

BTW: Was tempted ro add a boolean parameter case_sensitive to get_keyword() in css.utils to retrieve either token.lower_value or token.value

liZe added a commit that referenced this pull request Mar 18, 2019

@liZe

This comment has been minimized.

Copy link
Member

liZe commented Mar 18, 2019

BTW: Was tempted ro add a boolean parameter case_sensitive to get_keyword() in css.utils to retrieve either token.lower_value or token.value

I've added a get_custom_ident function. It's cheap and much clearer, we can use it everywhere it's needed.

Should be fixed by the 2nd and 3rd commit of this PR

It was, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.