Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow ability to ignore ssl verification within default_url_fetcher #847

Merged
merged 5 commits into from Apr 4, 2019

Conversation

2 participants
@mohdnajdy
Copy link
Contributor

mohdnajdy commented Apr 4, 2019

This fix is very helpful if i want to have images in html that are coming from un-trusted host.
This is applicable when i have a load balancer for all test servers and their global CA is not signed.

@mohdnajdy

This comment has been minimized.

Copy link
Contributor Author

mohdnajdy commented Apr 4, 2019

mohdnajdy added some commits Apr 4, 2019

@liZe

This comment has been minimized.

Copy link
Member

liZe commented Apr 4, 2019

Hello,

Thank you for this pull request!

Having this feature is interesting, but I'd prefer a ssl_context parameter (with a default value of None, directly passed to urlopen) instead of verify. It's more explicit and gives users the possibility to tweak the SSL connection to fit their needs.

@liZe liZe added this to the 47 milestone Apr 4, 2019

mohdnajdy added some commits Apr 4, 2019

@mohdnajdy

This comment has been minimized.

Copy link
Contributor Author

mohdnajdy commented Apr 4, 2019

Done @liZe

@liZe

This comment has been minimized.

Copy link
Member

liZe commented Apr 4, 2019

Thank you!

@liZe liZe merged commit f6f5cce into Kozea:master Apr 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.