Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for full CSS3 text-decoration [RFC] #855

Merged
merged 1 commit into from May 14, 2019

Conversation

2 participants
@randomstuff
Copy link
Contributor

commented Apr 23, 2019

  • parse text-decoration as shorthand
  • draw different colors
  • basic text-decoration-style
  • no 'wavy' support for now

One problem of the way it's currently done is that it makes weird glitches with dashed/dotted style when elements are found in the decorated text:

<p style="text-decoration: underline green dashed">Lorem <span>ipsum</span>
dolor sit amet, <span>consectetur</span> adipiscing elit, sed do eiusmod tempor 
ncididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud
exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.
Duis aute irure dolor in reprehenderit in voluptate velit esse cillum
dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt
in culpa qui officia deserunt mollit anim id est laborum.</p>
@randomstuff

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

This is trying to address #571.

Add support for full CSS3 text-decoration
* parse text-decoration as shorthand
* draw different colors
* basic text-decoration-style
* no 'wavy' support for now

@randomstuff randomstuff force-pushed the randomstuff:text-decoration branch from 9fb8ad0 to 9a73fff Apr 29, 2019

@liZe liZe added this to the 48 milestone May 14, 2019

@liZe liZe merged commit f5373db into Kozea:master May 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.