Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement bookmark-state support #870

Merged
merged 1 commit into from May 23, 2019

Conversation

2 participants
@randomstuff
Copy link
Contributor

commented May 17, 2019

Addresses #648

@randomstuff

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

Tests are currently broken. I think this is because the bookmarks are now all opened by default (as per the bookmark-state spec). I'm looking at it.

@randomstuff randomstuff force-pushed the randomstuff:bookmark-state branch from 040b17f to f1fc76d May 17, 2019

@randomstuff

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

I fixed the tests. The notable ugly hack is the BookmarkSubtree which tries to be API-compatible with the tuples which where used before.

@randomstuff randomstuff force-pushed the randomstuff:bookmark-state branch from f1fc76d to 3412735 May 19, 2019

@liZe

This comment has been minimized.

Copy link
Member

commented May 23, 2019

Thanks a lot! The code is clean and readable, it's a really nice feature to have. ❤️

@liZe liZe merged commit e881b66 into Kozea:master May 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@liZe liZe added this to the 48 milestone May 23, 2019

@liZe liZe referenced this pull request May 23, 2019

Closed

bookmark-state #648

liZe added a commit that referenced this pull request May 23, 2019

@liZe

This comment has been minimized.

Copy link
Member

commented May 23, 2019

For the record: I've cleaned a couple of things (mainly removing the tuple workaround) in 2ce0309.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.