Return appropriate tuple for string-set:none #975
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This snippet used to crash WeasyPrint with
UnboundLocalError: local variable 'computed_value' referenced before assignment
:Reason being the tuple-constructor in
computed_values.string_set()
splitting'none'
instead of a tuple consiting of a string-name and its string-value.BTW: WeasyPrint's unconventional way of handling
string-set
enables declarations likestring-set: none, stringname "value";
.