Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When changing Layout's attribute in set_text, do not override them #998

Merged
merged 1 commit into from Dec 15, 2019

Conversation

@knixeur
Copy link
Contributor

knixeur commented Nov 26, 2019

Between tags v43 and v44 there was a refactor in class Layout. Settings the layout attributes was done in one place and after the refactor it's done during setup() and somethings during set_text() call.
set_text's is overriding the attributes set by setup

@knixeur

This comment has been minimized.

Copy link
Contributor Author

knixeur commented Nov 26, 2019

Mmm maybe setup() should also update attributes instead of setting new ones since it's called from reactivate. I'm open to suggestions.
Also I didn't know how to test this without using mock/patch, let me know if there's some test I could use as base to test it.

@liZe liZe added the bug label Dec 15, 2019
@liZe liZe added this to the 51 milestone Dec 15, 2019
@liZe

This comment has been minimized.

Copy link
Member

liZe commented Dec 15, 2019

Thank you!

@liZe liZe merged commit 7d53bfd into Kozea:master Dec 15, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@liZe

This comment has been minimized.

Copy link
Member

liZe commented Dec 15, 2019

Related to #954.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.