New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localisation file for reflinks #34

Merged
merged 1 commit into from Feb 19, 2015

Conversation

3 participants
@zhaofengli
Contributor

zhaofengli commented Jan 10, 2015

Just a note that it's currently being used at https://tools.wmflabs.org/fengtools/reflinkstest/ (Chinese version). It's still incomplete.

The localisation is implemented with a custom msg() function in the Twig templating engine which calls Intuition's msg() method. See main.html for an example.

Thank you.

@Krinkle

This comment has been minimized.

Owner

Krinkle commented Jan 13, 2015

Looks good, but could you add qqq entries as well so translators know how the messages are used? And I noticed "wiki" is capitalised in your English messages, that should probably be changed to lowercase "wiki".

/cc @siebrand @Nikerabbit

@zhaofengli

This comment has been minimized.

Contributor

zhaofengli commented Jan 14, 2015

Thanks, I've changed 'Wiki' to lowercase and squashed the commits. I've prefixed most of the keys with their corresponding UI elements (heading, button label, etc). Is executable code allowed, so that I can add notes in batches for those messages to describe where they will be used?

@zhaofengli

This comment has been minimized.

Contributor

zhaofengli commented Jan 23, 2015

Hi, is this PR still being handled?

@siebrand

This comment has been minimized.

Contributor

siebrand commented Jan 23, 2015

We will look into it Monday or Tuesday.

Op 23 jan. 2015 om 02:57 heeft Zhaofeng Li notifications@github.com het volgende geschreven:

Hi, is this PR still being handled?


Reply to this email directly or view it on GitHub.

@siebrand

This comment has been minimized.

Contributor

siebrand commented Jan 26, 2015

qqq should be added for all messages in Reflinks.i18n.php. See https://www.mediawiki.org/wiki/I18n#Message_documentation for details.

@zhaofengli

This comment has been minimized.

Contributor

zhaofengli commented Jan 31, 2015

Okay, no problem!

@zhaofengli

This comment has been minimized.

Contributor

zhaofengli commented Feb 1, 2015

I've added the documentations.

@zhaofengli

This comment has been minimized.

Contributor

zhaofengli commented Feb 1, 2015

By the way, since the main copy of the message file is in the tool's repo, I'm a little bit concerned about the workflow. What's the best way to keep them in sync and how can I get new messages onto Translatewiki as soon as possible? Currently, Intuition is added as a git submodule in my repo, with a bootstrap script that loads the message file manually. The tool must be usable off-Labs.

Add localisation file for Reflinks
Signed-off-by: Zhaofeng Li <hello@zhaofeng.li>
// General messages
/*
Well, I remember the the translation interface in Launchpad gives an automatic hint about how to deal with the parameters.
Maybe the Translate extension can do the same? (Or am I missing something?)

This comment has been minimized.

@Krinkle

Krinkle Feb 11, 2015

Owner

It already does. Messages are inspected while they type. Omitting parameters yields a warning. The convention is to describe the message and how it is used. Optionally followed by a list of parameters and what they will contain. There's no need to assume the user will remove it, or to explain "run-time" concepts. Translators see those all the time (though using "run-time" probably adds more confusion then it helps avoid).

Please keep the $1 intact. It'll be replaced by a number at run-time.

May be better phrased as:

Indicates how many references were modified to have citations.

  • $1: The number of fixed references.

siebrand added a commit that referenced this pull request Feb 19, 2015

Merge pull request #34 from zhaofengli/master
Add localisation file for reflinks

@siebrand siebrand merged commit 309bf7d into Krinkle:master Feb 19, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment