Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar is broken for RTL in v1.3.0 #65

Closed
eranroz opened this issue Aug 11, 2016 · 2 comments
Closed

Sidebar is broken for RTL in v1.3.0 #65

eranroz opened this issue Aug 11, 2016 · 2 comments
Assignees
@Krinkle
Labels
type: bug

Comments

@eranroz
Copy link
Contributor

eranroz commented Aug 11, 2016

the sidebar goes into the page (left offset instead of right offset in RTL), making it impossible to use.

The .mw-rtrc-sidebar-toggleable #mw-panel rule should be splitted to .ltr version and .rtl version
@Krinkle
Copy link
Member

Krinkle commented Aug 11, 2016 •
edited

@eranroz Thanks, I've confirmed the issue. This is a regression in release v1.3.0.

I'll merge issue #50 into this as well, since it basically got worse from that.

screen shot 2016-08-13 at 00 53 52

@Krinkle Krinkle self-assigned this Aug 11, 2016
@Krinkle Krinkle changed the title RTRC is broken in RTL languages RTRC is broken for RTL in v1.3.0 Aug 11, 2016
@Krinkle Krinkle mentioned this issue Aug 11, 2016
Closed
@Krinkle Krinkle changed the title RTRC is broken for RTL in v1.3.0 Sidebar is broken for RTL in v1.3.0 Aug 11, 2016
@Krinkle Krinkle reopened this Sep 1, 2016
@mat-mo
Copy link

mat-mo commented Sep 1, 2016

rtrcscreenshot

@Krinkle Krinkle closed this as completed in 55d6313 Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Krinkle Krinkle

Labels
type: bug
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Krinkle @eranroz @mat-mo