Skip to content
This repository has been archived by the owner on May 2, 2022. It is now read-only.

Story #20 - Doctor Notification for Patient's Status Change #168

Merged
merged 10 commits into from
Apr 1, 2022
Merged

Conversation

fadi-albasha
Copy link
Collaborator

@fadi-albasha fadi-albasha commented Mar 31, 2022

Related Issue

Proposed Changes (Description)

  • Added generic notifications button and popover menu
  • Added notifications push at patient's status update

What will be affected:

  • Buttons should be moved from the header to the sidebar

Screenshots

image

Checklist

  • Tests
  • Documentation
  • Build Successful
  • Follow Coding Guidelines

@github-actions
Copy link

github-actions bot commented Mar 31, 2022

Visit the preview URL for this PR (updated for commit 01b2d4d):

https://soen-390-ba781--pr168-20-v6c1oxmi.web.app

(expires Fri, 08 Apr 2022 18:14:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@martinsenecal martinsenecal changed the title #20 Story #20 - Doctor Notification for Patient's Status Change Mar 31, 2022
Copy link
Collaborator

@martinsenecal martinsenecal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing Job! Can you just plz fix the failing tests and Cypress? When this is done, Ill approve it!

martinsenecal
martinsenecal previously approved these changes Apr 1, 2022
Copy link
Collaborator

@martinsenecal martinsenecal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

#20 removed extra empty line
Copy link
Collaborator

@martinsenecal martinsenecal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!

Copy link
Collaborator

@MilitsaB MilitsaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@fadi-albasha fadi-albasha added the story User Story label Apr 1, 2022
@fadi-albasha fadi-albasha merged commit 1527bd0 into dev Apr 1, 2022
@fadi-albasha fadi-albasha deleted the #20 branch April 1, 2022 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
story User Story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants