Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user id to email links #21

Merged
merged 1 commit into from Oct 4, 2017
Merged

Add user id to email links #21

merged 1 commit into from Oct 4, 2017

Conversation

jschr
Copy link
Collaborator

@jschr jschr commented Oct 1, 2017

Need user id in the email links and also made emails slightly nicer.

@jschr jschr requested a review from KristerV October 1, 2017 16:53
@KristerV
Copy link
Owner

KristerV commented Oct 2, 2017 •
edited

Isn't the token so unique that there is no need for userId? Or is it a optimization thing?

You can merge it either way. hmm how does the review thing work, can't find a way to access it :D

KristerV
KristerV approved these changes Oct 2, 2017
View reviewed changes
Copy link
Owner

@KristerV KristerV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah just wondering if userId is needed or is just an optimization thing?

@jschr
Copy link
Collaborator Author

jschr commented Oct 2, 2017

It's just because currently the route for updating includes the user id: users/:id/changePassword. The token is unique enough and in fact contains the user id but the frontend ideally shouldn't need to decode the token.

@KristerV KristerV merged commit b037f48 into KristerV:master Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristerV KristerV KristerV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jschr @KristerV