Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Incorrect plugin language when using PlaceholderField as a translated field #69

Merged
merged 2 commits into from Apr 8, 2013

Conversation

Projects
None yet
3 participants
Contributor

yakky commented Jul 14, 2012

Django-CMS javascript code that calls add_plugin() view looks for a input field named after the current language.
django-hvad language tabs lacks such a input: plugins are thus created in the current interface language instead of the current hvad language.
Adding the input fixes the problem.

This pull request passes (merged 115a912 into da398f2).

This pull request passes (merged fd76e78 into da398f2).

Hey,

Thanks a lot for your pull request. I'm not very involved in the django-cms development, so I will pass this review on to Jonas, if he has the time to look at it.

Kind regards,

Kristian

@ojii can you have a look at this? I'm not sure about what the CMS needs exactly or/and if this is something we should do in hvad.

@KristianOellegaard KristianOellegaard added a commit that referenced this pull request Apr 8, 2013

@KristianOellegaard KristianOellegaard Merge pull request #69 from nephila/commit_plugin_language
Incorrect plugin language when using PlaceholderField as a translated field
b9e24f4

@KristianOellegaard KristianOellegaard merged commit b9e24f4 into KristianOellegaard:master Apr 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment