Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Adds current language code for django-cms plugin editor #76

Closed
wants to merge 1 commit into from

3 participants

Bernardo Cabezas Serra Don't Add Me To Your Organization a.k.a The Travis Bot Kristian Øllegaard
Bernardo Cabezas Serra

Hello,
This issue has some history:
I made a pull request 4 months ago, including a input tag for making django-cms be able to get current language: cf4be06

You stated that would be better to include a tittle into the span, as a better solution to having a hidden element.

But this other solutions needs django-cms js plugin to be changed.

Just now i have seen a pull request which does the same:
Related to #69

This patch adds the title field to current span, and I have a django-cms pull request ready to be sent, which will add suport to get language from current span title (Also fixes another django-cms issue for language).

Maybe we should apply both solutions: the #69 for old django-cms instances to work, and this current span titlte for doing things well :).

Don't Add Me To Your Organization a.k.a The Travis Bot

This pull request fails (merged f2451f6 into 8c5b05e).

Kristian Øllegaard

Hi there,

As far as I know, this should be fixed in #69.

Kind regards,

Kristian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Aug 20, 2012
Bernardo Cabezas Serra bercab Adds current language code for django-cms plugin editor f2451f6
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 2 additions and 2 deletions. Show diff stats Hide diff stats

  1. +2 2 hvad/templates/admin/hvad/change_form.html
4 hvad/templates/admin/hvad/change_form.html
@@ -34,10 +34,10 @@
34 34 <div class="nani-language-tabs">
35 35 {% for url,name,code,status in language_tabs %}
36 36 {% if status == 'current' %}
37   - <span class="current">{{ name }}{% if current_is_translated and allow_deletion %}<a class="deletelink" href="./delete-translation/{{ code }}/" title="{% trans 'Delete Translation' %}">&nbsp;</a>{% endif %}</span>
  37 + <span class="current" title="{{code}}">{{ name }}{% if current_is_translated and allow_deletion %}<a class="deletelink" href="./delete-translation/{{ code }}/" title="{% trans 'Delete Translation' %}">&nbsp;</a>{% endif %}</span>
38 38 {% else %}
39 39 <span class="{{ status }}"><a href="{{ url }}">{{ name }}</a> {% if status == 'available' and allow_deletion %}<a class="deletelink" href="./delete-translation/{{ code }}/" title="{% trans 'Delete Translation' %}">&nbsp;</a>{% endif %}</span>
40 40 {% endif %}
41 41 {% endfor %}
42 42 </div>
43   -{% endblock %}
  43 +{% endblock %}

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.