Skip to content

Loading…

Adds current language code for django-cms plugin editor #76

Closed
wants to merge 1 commit into from

3 participants

@bercab

Hello,
This issue has some history:
I made a pull request 4 months ago, including a input tag for making django-cms be able to get current language: cf4be06

You stated that would be better to include a tittle into the span, as a better solution to having a hidden element.

But this other solutions needs django-cms js plugin to be changed.

Just now i have seen a pull request which does the same:
Related to #69

This patch adds the title field to current span, and I have a django-cms pull request ready to be sent, which will add suport to get language from current span title (Also fixes another django-cms issue for language).

Maybe we should apply both solutions: the #69 for old django-cms instances to work, and this current span titlte for doing things well :).

@travisbot

This pull request fails (merged f2451f6 into 8c5b05e).

@KristianOellegaard

Hi there,

As far as I know, this should be fixed in #69.

Kind regards,

Kristian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 20, 2012
  1. @bercab
Showing with 2 additions and 2 deletions.
  1. +2 −2 hvad/templates/admin/hvad/change_form.html
View
4 hvad/templates/admin/hvad/change_form.html
@@ -34,10 +34,10 @@
<div class="nani-language-tabs">
{% for url,name,code,status in language_tabs %}
{% if status == 'current' %}
- <span class="current">{{ name }}{% if current_is_translated and allow_deletion %}<a class="deletelink" href="./delete-translation/{{ code }}/" title="{% trans 'Delete Translation' %}">&nbsp;</a>{% endif %}</span>
+ <span class="current" title="{{code}}">{{ name }}{% if current_is_translated and allow_deletion %}<a class="deletelink" href="./delete-translation/{{ code }}/" title="{% trans 'Delete Translation' %}">&nbsp;</a>{% endif %}</span>
{% else %}
<span class="{{ status }}"><a href="{{ url }}">{{ name }}</a> {% if status == 'available' and allow_deletion %}<a class="deletelink" href="./delete-translation/{{ code }}/" title="{% trans 'Delete Translation' %}">&nbsp;</a>{% endif %}</span>
{% endif %}
{% endfor %}
</div>
-{% endblock %}
+{% endblock %}
Something went wrong with that request. Please try again.