Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

1 language on object creation, empty tabs at end, can't remove default translation, CSS changed #9

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
3 participants
  • Does not display additional language tabs on object creation, only default language
  • Empty language tabs go to the end
  • Can't remove default translation
  • CSS changed:
    • empty languages = color: #ccc
    • available but not currently selected = font-weight: normal
  • added __unicode__ method to BaseTranslationModel

Hi!

Thanks a lot for your pull request. As this is a project we use in many other projects and since it seems to be a cosmetic change, I'll have a look when i return to work in january.

Hope you had a great christmas and have a happy new year.

Kristian

@ojii ojii commented on an outdated diff Feb 16, 2012

nani/admin.py
status = 'available'
else:
status = 'empty'
- tabs.append((url, name, key, status))
+ if key == settings.LANGUAGE_CODE:
+ primary = True
+ else:
+ primary = False
+ tabs.append((url, name, key, status, primary, current))
+ scmp = lambda x,y: cmp((primary or y[3]!='empty'), x[3]!='empty')
@ojii

ojii Feb 16, 2012

Collaborator

NOT a fan of this. cmp is deprecated in Python to my knowledge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment