Permalink
Browse files

remove redundant exception handling an async base

StopIteration is simply propogated, so there's no reason to catch it.
The catch-all exception is also caught and logged in handle(), but
broken pipe errors are ignored. The redundant catch here was generating
excess logging by calling handle_error for a broken pipe which fails to
send the error because the client has already disconnected.
  • Loading branch information...
1 parent 4c2267b commit 21f7282128b372d111e751197c5d74cdaa7141af Randall Leeds committed Jul 8, 2011
Showing with 0 additions and 6 deletions.
  1. +0 −6 gunicorn/workers/async.py
@@ -71,12 +71,6 @@ def handle_request(self, req, sock, addr):
respiter.close()
if resp.should_close():
raise StopIteration()
- except StopIteration:
- raise
- except Exception, e:
- #Only send back traceback in HTTP in debug mode.
- self.handle_error(sock, e)
- return False
finally:
try:
self.cfg.post_request(self, req)

0 comments on commit 21f7282

Please sign in to comment.