Skip to content

schema.org/Book and schema.org/CreativeWork types has been added #12

Merged
merged 4 commits into from May 22, 2013

2 participants

@umurgdk
umurgdk commented May 21, 2013

I have added Book and CreativeWork types

@KrofDrakula KrofDrakula commented on an outdated diff May 22, 2013
jquery.microdata.js
@@ -44,7 +44,9 @@
// TODO: check three-letter ISO code for currency: http://www.iso.org/iso/support/faqs/faqs_widely_used_standards/widely_used_standards_other/currency_codes.htm
currency: function(value, el) { return (/^[a-zA-Z]{3}$/).test(value); },
- any: function(value, el) { return true; }
+ any: function(value, el) { return true; },
+
+ boolean: function(value, el) { return (/(True|False)/).test(value); }
@KrofDrakula
Owner
KrofDrakula added a note May 22, 2013

Maybe put the i flag on the regular expression to test for "true" and "false" in upper- and lower-case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@KrofDrakula
Owner

If you'll please fix up the indentation from 2 to 4 spaces, I'll gladly merge this pull request.

umurgdk added some commits May 22, 2013
@umurgdk umurgdk Indentation fixed 35e9907
@umurgdk umurgdk Revert "Indentation fixed"
This reverts commit 35e9907439feed41d421eda7eb61949be10faa88.
635986b
@umurgdk umurgdk Identation re-fixed 83b9559
@umurgdk
umurgdk commented May 22, 2013

Can you check it please.

@KrofDrakula
Owner

Great, thanks.

@KrofDrakula KrofDrakula merged commit dd77224 into KrofDrakula:master May 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.