New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Zero Days #11

Closed
ShaoKhan opened this Issue Nov 4, 2014 · 5 comments

Comments

Projects
None yet
3 participants
@ShaoKhan

ShaoKhan commented Nov 4, 2014

displayZeroDays: true,
shows correctly 0 days

displayZeroDays: false,
shows nothing if 1 day or more left

@KrzysiekF KrzysiekF self-assigned this Jan 7, 2015

@KrzysiekF KrzysiekF added this to the v1.4.2 milestone Jan 7, 2015

@KrzysiekF KrzysiekF added the bug label Jan 7, 2015

@KrzysiekF

This comment has been minimized.

Show comment
Hide comment
@KrzysiekF

KrzysiekF Jan 7, 2015

Owner

Hello,
Thank you for report.

Owner

KrzysiekF commented Jan 7, 2015

Hello,
Thank you for report.

@Chaos3ngel

This comment has been minimized.

Show comment
Hide comment
@Chaos3ngel

Chaos3ngel Jan 12, 2015

only registered on github for this comment ;)
awesome counter, cause its so easy and simple!
found fix for this bug... line 124 needs to be:
if ((_this.opts.displayDays && days > 0) || (_this.opts.displayZeroDays && days == 0)) {

only registered on github for this comment ;)
awesome counter, cause its so easy and simple!
found fix for this bug... line 124 needs to be:
if ((_this.opts.displayDays && days > 0) || (_this.opts.displayZeroDays && days == 0)) {

@KrzysiekF

This comment has been minimized.

Show comment
Hide comment
@KrzysiekF

KrzysiekF Jan 13, 2015

Owner

Hi,
Thank you very much :)

Owner

KrzysiekF commented Jan 13, 2015

Hi,
Thank you very much :)

@ShaoKhan

This comment has been minimized.

Show comment
Hide comment
@ShaoKhan

ShaoKhan Jan 13, 2015

appreciated ;) great work will be supportet hum ... ;)

appreciated ;) great work will be supportet hum ... ;)

KrzysiekF added a commit that referenced this issue Jan 13, 2015

KrzysiekF added a commit that referenced this issue Jan 13, 2015

@KrzysiekF

This comment has been minimized.

Show comment
Hide comment
@KrzysiekF

KrzysiekF Jan 13, 2015

Owner

Done.

Owner

KrzysiekF commented Jan 13, 2015

Done.

@KrzysiekF KrzysiekF closed this Jan 13, 2015

@KrzysiekF KrzysiekF reopened this Jan 13, 2015

@KrzysiekF KrzysiekF closed this Jan 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment