New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elm format works when used manually, but not on save - Possible issue on Windows? #191

Closed
hakonrossebo opened this Issue Feb 23, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@hakonrossebo
Collaborator

hakonrossebo commented Feb 23, 2018

This happens on my windows machine, but not on Linux. The same issue has also been reported here - https://discourse.elm-lang.org/t/fyi-for-anyone-with-vscode-who-updated-to-1-20-1/695

When debugging, this seems to work fine in stdout and in text replace, but somehow it does not show in the editor.

@adam77

This comment has been minimized.

Show comment
Hide comment
@adam77

adam77 Feb 24, 2018

Contributor

Do you have auto-save enabled?
format-on-save does not work when auto-save is enabled. This is a VSCode limitation.

Contributor

adam77 commented Feb 24, 2018

Do you have auto-save enabled?
format-on-save does not work when auto-save is enabled. This is a VSCode limitation.

@MartinKavik

This comment has been minimized.

Show comment
Hide comment
@MartinKavik

MartinKavik Feb 24, 2018

@hakonrossebo See Microsoft/vscode#41194 (comment) + other comments in that thread

Probably same issue: #175

MartinKavik commented Feb 24, 2018

@hakonrossebo See Microsoft/vscode#41194 (comment) + other comments in that thread

Probably same issue: #175

@hakonrossebo

This comment has been minimized.

Show comment
Hide comment
@hakonrossebo

hakonrossebo Feb 24, 2018

Collaborator

@adam77 - Thanks - no I don't have auto-save enabled. @MartinKavik - yes, this seems to be related. Verified that this format on save actually works on my Windows desktop machine - the "Running Save Participants" shows very briefly. On my Windows laptop format on save fails and the same status message is visible probably longer than 750ms. The laptop is a X1 Carbon 16GB 2017 model. On the same laptop, running Ubuntu 16.04, saving is fast and format on save works fine.

Collaborator

hakonrossebo commented Feb 24, 2018

@adam77 - Thanks - no I don't have auto-save enabled. @MartinKavik - yes, this seems to be related. Verified that this format on save actually works on my Windows desktop machine - the "Running Save Participants" shows very briefly. On my Windows laptop format on save fails and the same status message is visible probably longer than 750ms. The laptop is a X1 Carbon 16GB 2017 model. On the same laptop, running Ubuntu 16.04, saving is fast and format on save works fine.

@hakonrossebo

This comment has been minimized.

Show comment
Hide comment
@hakonrossebo

hakonrossebo Mar 8, 2018

Collaborator

I just verified the new formatOnSave timeout override that got merged into VSCode insider. Seems to work ok. Use:

"editor.formatOnSaveTimeout": 1500

I'm not sure if this is an acceptable solution, as my experience is that most Windows systems needs this setting for format on save to work?

Collaborator

hakonrossebo commented Mar 8, 2018

I just verified the new formatOnSave timeout override that got merged into VSCode insider. Seems to work ok. Use:

"editor.formatOnSaveTimeout": 1500

I'm not sure if this is an acceptable solution, as my experience is that most Windows systems needs this setting for format on save to work?

@Krzysztof-Cieslak

This comment has been minimized.

Show comment
Hide comment
@Krzysztof-Cieslak

Krzysztof-Cieslak Apr 20, 2018

Owner

It looks like setting "editor.formatOnSaveTimeout" is good suggested way forward for this feature.

Owner

Krzysztof-Cieslak commented Apr 20, 2018

It looks like setting "editor.formatOnSaveTimeout" is good suggested way forward for this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment