devel-docs/BugsAndFeatures

@@ -1,6 +1,3 @@
-White border around plot for black themes shouldn't be there.
-
--------------
 
 Equations could allow matrixes
   - Treated like vectors
@@ -9,22 +6,10 @@ Equations could allow matrixes
 
 -----------
 
-Should error out with no valid curves/matrixes displayed for non-empty command line?
-or specifying a file/limits should instead set defaults for wizard, etc?
-
--------------
-
-Icons are very small by default in UHD ubuntu 20.04
-
---------------
-
-Save a kst session.  File dialog recent files doesn't include ".kst" if it was
-automatically added on save.
-
-------------------
 When you open up kst file, opening another one tends to crash kst.
 
 ------------------
+
 No way to check matrix slave vector names in data manager.
 And slave scalar names are similarly not there.
 
@@ -117,20 +102,10 @@ pykst: accept non-float64 numpy arrays.
 
 FEATURES
 
-F3. Text labels have no background fill properties.
-
 F4. Nicer date tick marks.
 
-F5. Vector-choosing boxes should autocomplete.  i.e., if I have only one vector
-    derived from AZ_MAG (called, say, "AZ_MAG (V21)"), then I want to be able to
-    select that by typing "AZ_MAG" in the vector box, and not all of "AZ_MAG
-    (V21)".  (This is because users don't have any clue what the vector number
-    of the vector they want is.)
-
 F6. Non-integer curve stroke width.
 
-F9. Forward and back in smaller steps than whole screen.
-
 F11. Listfile subset
 
 F12. For fits, provide an (optional?) vector to evaluate over.

src/kst/x-kst.xml

@@ -11,6 +11,7 @@
     <comment xml:lang="eu">Kst-ko saio fitxategia</comment>
     <comment xml:lang="fr">Fichier de session pour « Kst »</comment>
     <comment xml:lang="it">File di sessione Kst</comment>
+    <comment xml:lang="ko">Kst 세션 파일</comment>
     <comment xml:lang="lt">Kst seanso failas</comment>
     <comment xml:lang="nl">Sessiebestand Kst</comment>
     <comment xml:lang="nn">Kst-øktfil</comment>

src/libkstapp/plotitem.cpp

@@ -1925,7 +1925,7 @@ void PlotItem::setSharedAxisBox(SharedAxisBoxItem* parent) {
     setAllowedGripModes(0);
     setFlags(0);
     setParentViewItem(parent);
-    setBrush(Qt::transparent);
+    //setBrush(Qt::transparent);
 
     _sharedBox = parent;
     createSharedAxisBoxMenu();
@@ -1935,7 +1935,7 @@ void PlotItem::setSharedAxisBox(SharedAxisBoxItem* parent) {
     setAllowedGripModes(Move | Resize | Rotate);
     setFlags(ItemIsMovable | ItemIsSelectable | ItemIsFocusable);
     setParentViewItem(0);
-    setBrush(Qt::white);
+    //setBrush(Qt::white);
 
     _sharedBox = 0;
   }

src/libkstapp/plotrenderitem.cpp

@@ -289,7 +289,16 @@ void PlotRenderItem::paint(QPainter *painter) {
 
   if (!view()->isPrinting()) {
     if (_selectionRect.isValid()) {
-      painter->setPen(QPen(QBrush(Qt::black), 1.0, Qt::DotLine));
+      QColor bgcolor = plotItem()->brush().color();
+      qreal r = bgcolor.redF();
+      qreal g = bgcolor.greenF();
+      qreal b = bgcolor.blueF();
+      qreal L = 0.2126*r*r + 0.7152*g*g + 0.022*b*b;
+      if (L>0.25) {
+        painter->setPen(QPen(QBrush(Qt::black), 2.0, Qt::DotLine));
+      } else {
+        painter->setPen(QPen(QBrush(Qt::white), 2.0, Qt::DotLine));
+      }
       painter->drawRect(_selectionRect.rect());
     }
   }

src/libkstapp/sharedaxisboxitem.cpp

@@ -83,7 +83,7 @@ void SharedAxisBoxItem::paint(QPainter *painter) {
     _dirty = false;
 
   }
-  painter->drawRect(rect());
+  //painter->drawRect(rect());
 }
 
 
@@ -293,7 +293,7 @@ void SharedAxisBoxItem::lockItems() {
   }
   if (!list.isEmpty()) {
     storePen(QPen(Qt::white));
-    setBrush(Qt::white);
+    //setBrush(Qt::white);
   }
 }
 

src/libkstapp/view.cpp

@@ -444,13 +444,12 @@ void View::forceChildResize(QRectF oldRect, QRectF newRect) {
 
 
 void View::drawBackground(QPainter *painter, const QRectF &rect) {
-  if (isPrinting()) {
-    QBrush currentBrush(backgroundBrush());
-    setBackgroundBrush(Qt::white);
-    QGraphicsView::drawBackground(painter, rect);
-    setBackgroundBrush(currentBrush);
-    return;
-  }
+//  if (isPrinting()) {
+//    QBrush currentBrush(backgroundBrush());
+//    QGraphicsView::drawBackground(painter, rect);
+//    setBackgroundBrush(currentBrush);
+//    return;
+//  }
 
   QGraphicsView::drawBackground(painter, rect);