Jit build matrix #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudo
reviewed
Jan 14, 2020
scripts/build.sh
Outdated
| @@ -11,7 +11,7 @@ GN_ARGS_BASE=" | |||
| v8_use_snapshot=true | |||
| v8_use_external_startup_data=false | |||
| icu_use_data_file=false | |||
| v8_enable_lite_mode=true | |||
| v8_enable_lite_mode=${DISABLE_JIT} | |||
There was a problem hiding this comment.
Just a nit.
Could you setup v8_enable_lite_mode like what NO_INTL did?
I.e.
Removing this line and add
if [[ ${DISABLE_JIT} -ne "false" ]]; then
GN_ARGS_BASE="${GN_ARGS_BASE} v8_enable_i18n_support=false"
fiOtherwise, for DISABLE_JIT mode, the generated GN config will be:
v8_enable_lite_mode= Explicit is better than implicit.
There was a problem hiding this comment.
i've made the change but i'm not sure its correct what you requested (in terms of true/false)
what is the default if you dont specify v8_enable_lite_mode?
There was a problem hiding this comment.
Yes, the change is exactly what I talked about.
The default value should be JIT enabled.
I am going to merge this PR and publish JIT versions once builds ready.
Thank you so much for your fantastic work.
Kudo
approved these changes
Jan 20, 2020
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs creates a build matrix with the nointl + jit features.
So result is
v8, v8-nointl, v8-jit, v8-jit-nointl
The new configuration also use jobs to run builds in parallel