A trait-based resolver API#303
Merged
Merged
Conversation
djc
commented
Oct 15, 2024
Contributor
Author
|
(Also feeding experience back into upstream: hickory-dns/hickory-dns#2509.) |
wez
reviewed
Oct 15, 2024
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wez what do you think of this direction? Might make sense to review the last commit first, the rest is sort of smaller/obvious stuff to get to this. As next steps, I'd add an
implfeature for the dns-resolver crate so that most dependencies don't need to pull in libunbound, then I can fold the crate-specificLookuptraits into the mainResolvertrait.(Part of the work towards SPF integration, see #83.)