Discard crate-specific DNS resolver traits#304
Conversation
d6433e9 to
8259962
Compare
23b8d39 to
33bc303
Compare
wez
left a comment
wez
left a comment
There was a problem hiding this comment.
I think this looks good, but I lost internet for a a couple of hours part way through and went on a side quest to troubleshoot why my backup connection stopped working, and I think I was in the middle of checking something to make a suggestion just before that happened, but have forgotten what it was!
I'll come back and re-review later!
| } | ||
|
|
||
| #[derive(Default)] | ||
| pub struct TestResolver { |
There was a problem hiding this comment.
thinking ahead for the higher level integration test use case, where it is desirable to shim in the zone/txt records from the kumod configuration, one way to achieve that is to have a version of TestResolver that includes an Option<Box<dyn Resolver>> that is consulted as a fallback when no records are found.
I don't thinks that changes what you are doing here in this PR, I'm just "thinking out loud"
There was a problem hiding this comment.
I don't yet understand the integration test setup well enough to speculate on this, but obviously there's a bunch of stuff we can do inside this. So far I think the deduplication of all the test resolvers and the resolver adapater [sic] have worked out pretty well...
|
Thanks! |
2 participants
r? @wez