New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create withConfig HOC #19

Open
jeanlescure opened this Issue Nov 26, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@jeanlescure
Copy link
Member

jeanlescure commented Nov 26, 2018

On implementing the Image component for #8 I added a timeout in case the image never loads.

In this example I should be able to set app-wide parameters to turn off the timeout for all <Image/> instances or to control the timeout length. I can see how we might want to have such parameters for many more non-theme related functionalities down the road.

We need a HOC that receives a config during transpiling and exposes it to the decorated component.

Since config is statically loaded one-time during code transpiling, I would avoid using Redux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment