Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit button is enabled during upload process #4429

Closed
sshcli opened this issue Aug 30, 2016 · 4 comments
Closed

Submit button is enabled during upload process #4429

sshcli opened this issue Aug 30, 2016 · 4 comments
Labels
bug
Milestone
5.0.2

Comments

@sshcli
Copy link
Member

sshcli commented Aug 30, 2016 •
edited

Steps to reproduce the issue

  1. Create a new topic and upload a big file (For example: 7 MB)
  2. Click the submit button before the upload process is complete.

Expected result

The submit button should be disabled until the upload process is complete.
Progress bar should be displayed.

Actual result

The new topic is created without the uploaded file.
Progress bar not being shown.

System information (as much as possible)

Joomla version: 3.6.2
Kunena version: 5.0.1
Php version: 7.0.10
Database version: 5.6.31

Additional comments
@sshcli sshcli added this to the 5.0.2 milestone Aug 30, 2016
@xillibit
Copy link
Member

I will look to disable submit button when the file is uploading, to show a progress bar i will do it in Kunena 5.1

@sshcli
Copy link
Member Author

sshcli commented Aug 31, 2016

Agree with your decision

xillibit added a commit to xillibit/Kunena-forum that referenced this issue Aug 31, 2016
@xillibit
Submit button is enabled during upload process Kunena#4429
f8ca158
@xillibit xillibit mentioned this issue Aug 31, 2016
Merged
xillibit added a commit to xillibit/Kunena-forum that referenced this issue Aug 31, 2016
@xillibit
Submit button is enabled during upload process Kunena#4429
4fa1bd9
xillibit added a commit to xillibit/Kunena-forum that referenced this issue Sep 1, 2016
@xillibit
Submit button is enabled during upload process Kunena#4429
bfcdcd2
810 pushed a commit that referenced this issue Sep 1, 2016
@xillibit @810
Submit button is enabled during upload process #4429 (#4435)
dbab155
@810 810 closed this as completed Sep 1, 2016
810 added a commit that referenced this issue Sep 1, 2016
@810
Merge K5.0 changes (#4439)
e1525d9 

* add category view (#4055)

* Fix fatal on category view (#4056)

* Release Kunena 5.0 RC3 (#4057)

* Set Dev (#4058)

* Seo: Duplicated title in Category view (#4059)

* Fix button on Crypsisb3 for quickreply (#4060)

* Language: improve string index (#4061)

* Fix title issue on after (#4063)

* remove apple color emoji because its breaking padding in the message (#4062)

* Add id to buttons, for custom changes (#4064)

* Backend: Logs improve calendar view (#4065)

* Backend: Categories more space for title (#4066)

* Improve Seo (#4067)

* Ebay from cache #4014 (#4077)

* Improve Seo on pages (#4081)

* Improve topic actions (#4080)

* Fix big image insert width (#4082)

* On Crypsis is missing the option category jump #3984 (#4024)

* Html fixes (#4085)

* Crypsisb3: Add forumjump (#4084)

* Reintegrate methods in view.html.php into topic for kunena discuss (#4088)

* Remove deprecated code for maps in bbcode.php (#4090)

* When only confidential content is present in message guests and unallowed users see empty message #4075 (#4092)

* K5.0 RC3 - Crypsis - Old DIV not in use still present #4076 (#4093)

* If Thank You is disabled, the Unthank button remains #4039 (#4094)

* Google maps API key needed #4086 (#4089)

* Crypsis: remove badger-solved (#4096)

* Email header img should come from website, not git #4070 (#4097)

* Remove deprecated js (#4098)

* Rendering Error in layout Topic/List #4101 (#4102)

* You can't go to the next page on search results (it goes back to the search) #4100 (#4103)

* CrypsisB3: display issues of poll settings #4035 (#4104)

* Fix all Module Position Kunena issues

* Module Position Kunena_topic_x is inverted #4095
* modules are showed multiple times #3839
* Crypsis shows the module by post number in a topic #3687

* CrypsisB3: poll icon in editor not hidden on default load #4034 (#4106)

* Crypsisb3: Quick reply only first message is working #4083 (#4107)

* With "Adds Suffix to URL = Yes" no attachments and images are available in the forum #4017  (#4108)

* Instagram fix height and width (#4109)

* Release RC4 (#4110)

* Set dev (#4112)

* Rendering Error in layout Topic/List: Property "categorylist" is not defined #4111 (#4113)

* Show whatsapp only on mobile (#4114)

* Missing config parameter in call of BBCode/Map layout (#4115)

* Fix check to make difference between image ad file in attachments (#4116)

* Restore Unapproved Topics not working as expected #4118 (#4119)

* No description when hover the mouse over a topic #3849 (#4121)

* Error in Duplicated Alias for Categories #3999 (#4122)

* Show page title only on >1 page (#4125)

* Fix strings related to topic rate (#4127)

* Prevent to have utf-8 characters in attachment filenames #4099 (#4126)

* Bbcode size tools are not translated #4069 (#4128)

* Error in Duplicated Alias for Categories (convert js to jQuery) #3999 (#4129)

* html is lost on submit #4022 (#4130)

* Improve code (#4131)

* Image edit shows only image place holder #4117 (#4132)

* Delete blue eagle directory and blue eagle language files during install (#4134)

* Topics in the unapproved view don't have the "Move" option #4073 (#4136)

* Display message in notice on message action or topic action (#4139)

* Fix missing locked icons on message row (#4144)

* Auto embed soundcloud #3744 (#4142)

* Error 404 pages are not translated #4137 (#4143)

* Show string, if no maps api key is set. #4138 (#4141)

* hide time filter only on profile page #4145 (#4146)

* Hide filter on bottom (#4147)

* URL from subscriptions with Crypsis are weird #3847 (#4149)

* Update bbcode language (#4133)

* Duplicate Page Title in Recent Topics Menu Item only if Browser Page Title field has a value #4150 (#4151)

* Fix incorrect string for topic rate (#4152)

* Fix closing modals quickreply (#4153)

* Add Page heading support on menu items (#4154)

* Crypsis: improve profilebox (#4157)

* Remove comments on email (#4160)

* Auto embed youtube: add embed link support (#4162)

* Login link at bottom of messages go to top of page, it should open modal login box #4148 (#4159)

* Release K5.0 RC5 (#4163)

* Set dev6 (#4164)

* Remove page title override on non active menus (#4165)

* Improve Seo topic page (#4166)

* Crypsisb3: fix modal report (#4168)

* Ban with delete all post doesn't delete all post (it deletes only the (#4170)

* Strip bbcode on description (#4171)

* Mobile Images not Rotating Based on EXIF Data #4123 (#4172)

* Diagnostics (error found) link not working #3939 (#4173)

* Crypsis: Make the dropdown bigger (#4174)

* Check if folder language exist in Kunena directory to avoid issue (#4175)

* Crypsis: Add placeholder message (#4176)

* Topic move: Wrong language string (#4177)

* Remove sprintf on tooltip, causes errors (#4179) Thnx Kyle

* fixes link escaping and improves tooltip usage with user content (#4180)

* Codestyle backend controllers (#4181)

* Mobile Images not Rotating/flip Based on EXIF Data #4123 (#4182)

* Email: subscription reply is missing host name #4178 (#4183)

* Missing version of AltaUserPoints in Kunena configuration report (#4184)

* Fix call for altauserpoints avatar because some methods are disappear in (#4186)

* Fix wrong language strings video (#4185)

* Update: Save template settings + custom less/css file (#4188)

* Remove deprecated tables (#4189)

* Add check on remove blue eagle (#4190)

* Crypsis: Fix floating attachments (#4191)

* KunenaIcons: Add rss icon (#4192)

* Labels: improve default colors (#4194)

* Fix login users with spaces (#4196)

* Improve donation to Kunena (#4197)

* Add PHP7 support travis (#4198)

* Add trigger on sidebar (#4200)

* Add PHP 7.1 check (#4202)

* Crypsis template setting "Display modules" works only for a few module positions #4201 (#4203)

* Module position Announcement shows the module twice if an announcement is published #4204 (#4205)

* Issue with php7.0.9 with usage of JError (#4206)

* Remove last usage of JError::raiseError and JError::raiseWarning (#4207)

* Set the method checkDatabaseError() deprecated in KunenaError class (#4208)

* Fix name update site (#4213)

* Update to https update server (#4215)

* Edit on first message cause wrong redirect if category is under review #4216 (#4217)

* The option "Message title length" has always 50 characters #4218 (#4219)

* Improve login (#4222)

* Edit topic under review, do not redirect if moderator (#4221)

* Fix fatal error: missing kunenatemplate (#4223)

* Fix icons on message actions (#4225)

* Fix padding issues message state (#4227)

* Set method getDatabaseError deprecated in KunenaError class (#4224)

* Warning: Kunena: Incompatible template blue_eagle, using crypsis instead. #4228

* Backend: Change modal changelog to link (#4230)

* Update languages (#4231)

* Avoid to duplicate code to remove html at the end of attachment url (#4226)

* Fix some last minute bugs (#4235)

* Error: You cannot put an URL in the subject of the topic or message. #4236 (#4237)

* Revert markitup.editor.js (#4238)

* Upload image gives notices and warning on error log #4232  (part2) (#4239)

* Insert attachments in the right line (#4240)

* Release K5.0 (#4242)

* Prepare 5.0.1 dev (#4243)

* Labels: Moderate topic can now change labels if topicicons is turned off (#4195)

* Hard coded title forum access (#4220)

* small typo on message item (#4250)

* Replace usage of checkDatabaseError() by exception in backend (#4251)

* Error in URL (Notification Emails) #4257 (#4258)

* Crypsisb3 Labels: Moderate topic can now change labels if topicicons is turned off #4256 (#4259)

* COM_KUNENA X_TOPICS string missing #4254 (#4261)

* Mouseover shows wrong informations if is a Email address in the message #4255 (#4260)

* Remove some of the usage of JRequest which is deprecated (#4266)

* Add translations for JSsocials items (#4269)

* Improve Meta Description for Sections / Categories #4267 (#4268)

* Seo: Add nofollow on tabs users (#4270)

* Attachment manager limited to 30 (fix from rtv3) (#3804)

* Upload rank images and emoticons are not possible #4272 (#4273)

* Attachment manager limited to 30 (fix from rtv3)(missing in crypsisb3) (#4274)

* Add nofollow for modules kunenaforum.link (#4277)

* Seo: Add nofollow on unread items #4275 (#4276)

* Recent Topics page shows correct admin and moderator colors according to the random principle #4212 (#4278)

* Upgrade from K4 to K5 : Warning Destination folder already exists #4248 (#4280)

* Crypsis: Set Topic Icons default for custom icons #4264 (#4279)

* Update issue:  correct the file name (#4282)

* Announcements will not published #4271 (#4285)

* Fix social icons (#4287)

* Fancybox: missing icons (#4291)

* Hardcoded texts in the Log Manager #4281 (#4293)

* Seo: Add nofollow and noindex (#4292)

* Improve custom less file load (#4294)

* change maxlength="35" to only check if correct email #4246 (#4295)

* Edit preferences is always kunena settings #4252 (#4299)

* Fix follow on category/item (#4298)

* The minus symbol at the Poll options is inactive #4296 (#4302)

* Fix input announcement date (#4304)

* Page broken when ebay link with allow_url_fopen turned off #4290 (#4307)

* Empty topic with a blank image in the content #4284 (#4308)

* Seo: Improvements (#4311)

* Empty topic with a blank image in the content #4284 (Part 2) (#4312)

* Seo: Fix misc pages (#4313)

*  Empty topic with a blank image in the content #4284 (Part 2) (#4314)

* Announcements will not published #4271 (Part 2) (#4315)

* Edit User Account is not possible #4309 (#4316)

* Move correctImageOrientation into KunenaImage class (#4318)

* Update travis (#4321)

* Enabled Gravatar Defalt Image feature (#4320)

* No longer view GM+ ban history #4310 (#4323)

* Rank system doesn't respect the state "disabled" #4319 (#4322)

* Add onKunenaUserTabs trigger (#4324)

* Seo: need some improvements #4289 (#4325)

* Crypsisb3: edit profile fix button (#4326)

* Last edit: no check if moderator is moderator on this category #4210 (#4327)

* Update vimeo (#4328)

* Seo: Fix meta links canonical (#4330)

* Fix sprite twitter (#4331)

* Fix breadcrumb on profile (#4333)

* Crypsis: show message on title (#4334)

* Seo: search results (#4335)

* Wrong path specification in administrator com_kunena.views.ini line 285 #4336 (#4337)

* seo: edit topic (#4338)

* Missing text for COM_KUNENA_MODERATION_TARGET_TOPIC_ID #4339 (#4340)

* Thumbnail image is broken when protect attachments = yes #4329 (#4341)

* Custom settings for crypsis are lost when update kunena #4345 (#4346)

* The method setLegacy() is needed in discuss plugin (#4347)

* BBCode img height and alt are missing #4068 (#4344)

* Subscription notifications that contain iframe are considered like spam (#4349)

* Seo: set follow as default (#4350)

* Seo: fix nofollow on plugins/modules (#4352)

* SEO: Meta Description is Duplicated in Recent Topics #4354 (#4355)

* Language: Update languages (#4356)

* Restored subscribe field id (#4357)

* Name field is optional when reply a topic (Guests) #4351 (#4359)

* Amended category alias can't to undo #4358 (#4361)

* Update language (#4360)

* Name field is optional when reply a topic (Guests) #4351 (change in (#4362)

* Cypsis: Update html to h1 on new topic page (#4363)

* Release K5.0.1 (#4364)

* Prepare 5.0.2 dev (#4365)

* Fix video size youtube (#4369)

* Final replacement of last calls of remaining JRequest (#4367)

* Update default.php (#4370)

* Modify message on new topic/reply for guests, to indicate that they (#4368)

* CB avatar and name links to base url #4372 (#4373)

* Languages: update (#4374)

* Crypsisb3: fix moderation (#4376)

* PLG_KUNENA_COMPROFILER_NO_GROUPS_FOUND #4377 (#4379)

* Remove deprecated code and/or obsolete (#4378)

* Add option to replace brand image in notification emails #4375 (#4381)

* Restored id to fields Subject and Topic Icons (#4382)

* Update language string (#4383)

* fix to preserve upload path when sending file attachment upload (#4385)

* Subscription notifications that contain iframe are considered like spam (#4387)

* Category Manager | Save as Copy or Save & New refreshes only the (#4388)

* Moderate New Users: Pending messages are hard to find #4249 (#4389)

* Message row: show message on title (#4390)

* The option Use English On Missing Strings works not for the file site-com_kunena.ini #4391 (#4392)

* Forum category page title with html entities are not converted correctly. #4395 (#4396)

* Username shows on search when Full Name is set in config (#4398)

* Language: Update string (#4400)

* Fix total topics on index page (#4402)

* Add suffix breaks preview #4401 (#4403)

* Fix hard coded strings on search results (#4404)

* Fix mb_substr on subject titles (#4384)

* Move ajax type to post #4406 (#4409)

* Update jssocials to 1.3.1 (#4412)

* Code cleanup (#4413)

* Set correct error code #4410 (#4417)

* search pagination broken #4397 (#4418)

* kunenaforum.categorylist supports array $parent #2581 (#4419)

* Code style improvements (#4420)

* crypsisb3 minor fixes (#4421)

* Update unit test (#4422)

* Confirm message before deleting users #4286

* Undefined variable: attachs

* Jsocials, use https on facebook (#4433)

* The word "Donate" is not translated #4394 (#4436)

* Update travis (#4438)

* Submit button is enabled during upload process #4429 (#4435)
@xillibit
Copy link
Member

xillibit commented Sep 13, 2016 •
edited

I will look to disable submit button when the file is uploading, to show a progress bar i will do it in Kunena 5.1

Add a new entry for progress bar else it will forgotten

@sshcli sshcli mentioned this issue Sep 13, 2016
Closed
@sshcli
Copy link
Member Author

sshcli commented Sep 13, 2016

Add a new entry for progress bar else it will forgotten

Done. #4498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
5.0.2
Development

No branches or pull requests
3 participants
@xillibit @810 @sshcli