New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous ban blocks ability for Thank you #5955

Open
baticag opened this Issue May 28, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@baticag

baticag commented May 28, 2018

Describe the bug
When you ban a user on forum and that ban expires, he still cannot use the Thank you option on any post.

To Reproduce
Steps to reproduce the behavior:

  1. Ban a user
  2. Unban the user or wait for ban to expire
  3. Try to give Thank you on some post

Expected behavior
User should have the ability to use Thank you option after the ban expires.

Actual result
User doesn't have the ability to use Thank you option after the ban expires.

Screenshots
If applicable, add screenshots to help explain your problem.

System information (please complete the following information)

Joomla version: 3.8.8
Kunena version: 5.0.8
Php version: 5.6.30
Database version: 3.8.6-2018-02-14

Desktop (please complete the following information):
Any desktop.

Smartphone (please complete the following information):
Any smartphone.

Additional context
I tried to identify the source of the problem and I saw that problem occurs when user's row in joomla_kunena_users table has a date in banned field and not NULL. When you unban the user or ban expires that value doesn't change back to NULL.

@810

This comment has been minimized.

Member

810 commented May 29, 2018

For me its ok, but there is a issue, that the time as saved as utc. this can be your issue

810 added a commit that referenced this issue May 29, 2018

@810

This comment has been minimized.

Member

810 commented May 29, 2018

I think i have fix it, from now its the server time instead utc.

@810 810 closed this May 29, 2018

@xillibit xillibit reopened this Jun 1, 2018

@xillibit

This comment has been minimized.

Member

xillibit commented Jun 1, 2018

The fix cause other issue : #5966, so i reopen it

@xillibit xillibit added bug 5.1 labels Jun 1, 2018

@xillibit xillibit added this to the 5.1.1 milestone Jun 1, 2018

@810 810 modified the milestones: 5.1.1, 5.1.2 Jun 22, 2018

@xillibit xillibit modified the milestones: 5.1.2, 5.1.3 Jul 16, 2018

@810 810 modified the milestones: 5.1.3, 5.1.4 Aug 31, 2018

@810 810 self-assigned this Sep 10, 2018

@810 810 modified the milestones: 5.1.4, 5.1.6 Oct 14, 2018

@xillibit xillibit modified the milestones: 5.1.6, 5.1.8 Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment