New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename social Odnoklassniki #5988

Closed
mc-hovanskiy opened this Issue Jun 14, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@mc-hovanskiy

mc-hovanskiy commented Jun 14, 2018

Change the name of the social network. It is necessary that instead of ok there was odnoklassniki.
This creates problems with FontAwesome icons.

www\libraries\kunena\user\user.php
line 2138:
'odnoklassniki' => array('url' => 'https://ok.ru/##VALUE##', 'title' => JText::_('COM_KUNENA_MYPROFILE_OK'), 'nourl' => '0'),

I edit the 2084 line in this file so:
return '<a href="' . $this->escape($url) . '" ' . ' target="_blank" title="' . $title . ': ' . $value . '"><span class="fab fa-' . $name . '"></span></a>';

All the buttons I use are displayed correctly except for classmates, since they have an icon:
<i class="fab fa-odnoklassniki"></i>
https://fontawesome.com/icons/odnoklassniki?style=brands

Can I put these buttons social networks in a file that I can override later, so that I do not manually delete unnecessary social networks?
Thanks!

@xillibit xillibit added this to the 5.1.1 milestone Jun 16, 2018

@mc-hovanskiy

This comment has been minimized.

mc-hovanskiy commented Jun 16, 2018

And remove from the list of social networks icq. This is an obsolete messenger and has long been unused. ICQ is dead.

@810 810 modified the milestones: 5.1.1, 5.1.2 Jun 22, 2018

810 added a commit that referenced this issue Jun 27, 2018

@810

This comment has been minimized.

Member

810 commented Jun 27, 2018

This shoulbe be done by language file only.

icq is still live.

@mc-hovanskiy

This comment has been minimized.

mc-hovanskiy commented Jun 27, 2018

Can I rename it?

www\libraries\kunena\user\user.php
line 2138:
'odnoklassniki' => array('url' => 'https://ok.ru/##VALUE##', 'title' => JText::_('COM_KUNENA_MYPROFILE_OK'), 'nourl' => '0'),

@810

This comment has been minimized.

Member

810 commented Jun 27, 2018

No, then you need to change database also, so I have ok for the code. And use Odnoklassniki on the language strings.

@mc-hovanskiy

This comment has been minimized.

mc-hovanskiy commented Jun 27, 2018

Sorry, after correction to the class, the icon in the user's profile will be "odnoklassniki"? I need to rename the button class css in the user profile. I thought the class is taken from the code I specified.

icq bought mail.ru (he buys dead projects that were once popular). For 8 years nobody has been using ICQ, but the site exists.
I do not insist, I just decided to let you know because I know ICQ and when I used it.

@mc-hovanskiy

This comment has been minimized.

mc-hovanskiy commented Jun 27, 2018

It is necessary that the ccc class be: kicon-profile kicon-profile-odnoklassniki
Now: kicon-profile kicon-profile-ok

2018-06-27_151537

@810

This comment has been minimized.

Member

810 commented Jun 28, 2018

For now we need to use ok.
For Kunena 6.0 we can use the full name. Else there will be b/c issues with templates.

The kicon-profile-ok is correct.

@810 810 closed this Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment