New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two menus #6172

Closed
mc-hovanskiy opened this Issue Dec 1, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@mc-hovanskiy
Copy link

mc-hovanskiy commented Dec 1, 2018

In code Kunena there are two menus, one of which is hidden by styles.
It is not right. They switch at the expense of classes visible-desktop and hidden-desktop.
HTML validator sees errors: duplicate id klogin and id of login buttons through social networks, displayed in module position of dropdown-menu.

File www\components\com_kunena\template\crypsis\layouts\widget\menubar\default.php

Template - Crypsis
Kunena - 5.1.7

@810

This comment has been minimized.

Copy link
Member

810 commented Dec 7, 2018

this should be fixed already.

chrome doesn't show this error. I just fixed 2 other dom issues.

@mc-hovanskiy

This comment has been minimized.

Copy link

mc-hovanskiy commented Dec 9, 2018

Validator HTML (https://validator.w3.org/) easily finds duplicate IDs and marks them as an error.

Dubli id: id="klogin" and id="userdropdown"

Screenshots from site Kunena, page: https://www.kunena.org/forum/index in confirmation:

2018-12-09_041349

2018-12-09_041426

Two menus in code:

2018-12-09_041147

810 added a commit that referenced this issue Dec 9, 2018

@810 810 added enhance 5.1 labels Dec 9, 2018

@810 810 added this to the 5.1.8 milestone Dec 9, 2018

@810 810 closed this Dec 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment