Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary text labels always change to [Question] when Topic is Sticky or Locked #6194

Open
rich20 opened this Issue Jan 18, 2019 · 3 comments

Comments

Projects
None yet
4 participants
@rich20
Copy link
Member

rich20 commented Jan 18, 2019

Describe the bug
https://www.kunena.org/forum/k5-1-support/156440-primary-text-labels-always-change-to-question-when-topic-is-sticky-or-locked

To Reproduce
Steps to reproduce the behavior:

  1. Use default setting "Selectable Topic Icons = Yes"
  2. Choose "Show Labels = Topic id"
  3. Mark a topic as Sticky (or Locked)
  4. Try to change the label

Expected behavior
It should switch automatically to the "Important" (or locked) label. At least it should be able to be changed it manually.

Actual result
It changes to the label "Question" and it's not possible to use another label.

Screenshots
If applicable, add screenshots to help explain your problem.

System information (please complete the following information)

Joomla version:
Kunena version:
Php version:
Database version:

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@rich20 rich20 added bug 5.1 labels Jan 18, 2019

@rich20 rich20 added this to the 5.1.9 milestone Jan 18, 2019

810 added a commit that referenced this issue Feb 5, 2019

@810 810 closed this Feb 5, 2019

@Ruud68

This comment has been minimized.

Copy link
Contributor

Ruud68 commented Feb 19, 2019

Hi, just installed 5.1.9 and now I experience the same behaviour. Not sure if this PR made it into 5.1.9 (change log is empty)...
Reverting back to 5.1.8 solves the problem.

peek 2019-02-19 09-32

@xillibit

This comment has been minimized.

Copy link
Member

xillibit commented Feb 19, 2019

I re-open the issue, if it re-appear

@xillibit xillibit reopened this Feb 19, 2019

@xillibit xillibit modified the milestones: 5.1.9, 5.1.10 Feb 19, 2019

@810 810 modified the milestones: 5.1.10, 5.1.11 Mar 3, 2019

@Ruud68

This comment has been minimized.

Copy link
Contributor

Ruud68 commented Mar 4, 2019

Hi,
the 'feature' of changing the labels to question on locked topics is introduced by this change:
dab6ee5

When reverting this change, the issue is solved and when locking a topic, the original topic label is displayed.
I have no idea as to why this change was done.
for me this is blocking as the labels are used in my support 'system', locking a topic and changing the label on that topic to question breaks that 'system'.

So I guess that if this change is a result of a feature request, then at least make it a config setting: change label when locked/stocky 'yes/no'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.