Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity Integration don't call every activity plugins #2580

Merged
merged 2 commits into from Sep 6, 2014
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -47,10 +47,14 @@ static public function getInstance() {
* @return mixed
*/
public function __call($method, $arguments) {
$ret = null;
foreach ($this->instances as $instance) {
if (method_exists($instance, $method)) {
return call_user_func_array(array($instance, $method), $arguments);
$r = call_user_func_array(array($instance, $method), $arguments);
if($r !== null & $ret === null)

This comment has been minimized.

Copy link
@mahagr

mahagr Sep 6, 2014

Member

@obsidev Just a question here: what are you trying to return in here?

You probably ment to use && instead of bitwise and (even if it works) but I can also see that you're returning only the first value and not considering the other results at all.

This comment has been minimized.

Copy link
@obsidev

obsidev Sep 6, 2014

Author Contributor

The "no return" was fine for me but I tried to manage the issue #2225
Which results the commit 9a08827

$ret = $r;
}
}
return $ret;
}
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.