Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1] Category Image Path: does not work #2726 #2894

Merged
merged 5 commits into from
Jan 23, 2016
Merged

Conversation

xillibit
Copy link
Member

No description provided.

@xillibit
Copy link
Member Author

@GJSchaller : can-you test it please ?

@GJSchaller
Copy link

Testing - using Crypsis - set the path to "klarington" in the Crypsis config.

Path to Category Icons should be:

(joomla root)/media/kunena/klarington

but instead it is:

(joomla root)/components/com_kunena/template/crypsis/media/topic_icons/default/system/

For Blue Eagle, it is:

(joomla root)/media/kunena/topic_icons/default/system/normal.png

I may have goofed the files - if you want access to my test site, please let me know.

@810 810 added this to the 4.0.0 milestone Apr 1, 2015
@810
Copy link
Member

810 commented Apr 2, 2015

i want to move all crypsis media to media/kunena

Then there is no issue any, also i have a new pr, that's improving the topic icons

@xillibit
Copy link
Member Author

I have updated it, for blue eagle and old templates this won't change nothing and till use setting under Kunena configuration panel but for Crypsis and new templates this path need to be set under template settings.

@810 810 modified the milestones: 4.0.0, 4.0.3, 4.0.4 Jun 26, 2015
@810 810 modified the milestones: 4.0.4, 4.0.5, 4.0.6 Aug 16, 2015
@810 810 modified the milestones: 4.0.6, 4.0.7 Sep 28, 2015
@810 810 removed this from the 4.0.6 milestone Sep 28, 2015
@810 810 modified the milestones: 4.0.7, 4.0.8 Nov 16, 2015
@810 810 modified the milestones: 4.0.8, 4.0.9 Jan 12, 2016
$path = JPATH_ROOT . '/media/kunena/' . $catimagepath . '/';
$uri = JUri::root(true) . '/media/kunena/' . $catimagepath . '/';

if (!$thumb)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be if ($category->getNewCount()) I think

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of php if (!thumb) ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, because i can't see what $thumb is. before it was also with that code.

@xillibit
Copy link
Member Author

@810 : should be ok now

@810
Copy link
Member

810 commented Jan 20, 2016

can't see the option on edit template

@810 810 modified the milestones: 4.0.9, 4.0.10 Jan 21, 2016
@xillibit
Copy link
Member Author

The option COM_KUNENA_CATIMAGEPATH_LEGACY is on Kunena configuration

@rich20
Copy link
Member

rich20 commented Jan 21, 2016

  • Failed - Crypsis shows this error instead of category icons

Notice: Undefined variable: defaultcategoryicon in components/com_kunena/layout/category/index.php on line 71

@xillibit
Copy link
Member Author

Try now

@rich20
Copy link
Member

rich20 commented Jan 23, 2016

  • Crypsis shows error - Succes
  • Image path - Success

810 added a commit that referenced this pull request Jan 23, 2016
[3.1] Category Image Path: does not work #2726
@810 810 merged commit 18b8d10 into Kunena:develop Jan 23, 2016
@xillibit xillibit deleted the k31_bugs3 branch February 26, 2017 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants