Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix the search when no "search at date" #4642
Conversation
810
added
bug
5.0
labels
Oct 3, 2016
810
added this to the 5.0.3 milestone
Oct 3, 2016
810
merged commit ef04f9b
into
Kunena:K5.1
Oct 3, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
obsidev commentedOct 3, 2016
Pull Request for Search Issue.
Summary of Changes
The "search at date" can accept an empty value as a non-value.
The reading of the input (line 71) will put "null" as the default value ; which will force the search on a specific "null" date, converted automatically into "now".
Testing Instructions
When the field "search at date" is not displayed in the search form, it is not possible to perform a valid search.