Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last change to replace typehead usage with at.js broke the dropdown users list #4941

Merged
merged 1 commit into from
Nov 13, 2016

Conversation

xillibit
Copy link
Member

@xillibit xillibit commented Nov 11, 2016

Pull Request for Issue # .

Summary of Changes

Testing Instructions

@xillibit xillibit added this to the 5.0.4 milestone Nov 11, 2016
@xillibit xillibit changed the title Last change to replace typehead usage with at.js broke the dropdown Last change to replace typehead usage with at.js broke the dropdown users list Nov 11, 2016
@810
Copy link
Member

810 commented Nov 11, 2016

when i click on the scrollbar to scroll to bottom, then the menu is gone. need to be active

@@ -15,17 +15,17 @@ jQuery(document).ready(function($) {

$('#kusersearch').atwho({
at: "",
tpl: '<li data-value="${username}"><span class="glyphicon glyphicon-user"></span> ${username} <small>(${name})</small></li>',
displayTpl: '<li data-value="${name}"><span class="icon icon-user"></span> ${name} <small>(${name})</small></li>',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to be glyphicon

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which glyphicon should need to use ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glyphicon glyphicon-user

@810 810 merged commit 38e8400 into Kunena:K5.0 Nov 13, 2016
@xillibit xillibit deleted the K5.0_bugs24 branch February 26, 2017 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants