New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last change to replace typehead usage with at.js broke the dropdown users list #4941

Merged
merged 1 commit into from Nov 13, 2016

Conversation

Projects
None yet
2 participants
@xillibit
Member

xillibit commented Nov 11, 2016

Pull Request for Issue # .

Summary of Changes

Testing Instructions

@xillibit xillibit added 5.0 bug labels Nov 11, 2016

@xillibit xillibit added this to the 5.0.4 milestone Nov 11, 2016

@xillibit xillibit changed the title from Last change to replace typehead usage with at.js broke the dropdown to Last change to replace typehead usage with at.js broke the dropdown users list Nov 11, 2016

@810

This comment has been minimized.

Member

810 commented Nov 11, 2016

when i click on the scrollbar to scroll to bottom, then the menu is gone. need to be active

@@ -15,17 +15,17 @@ jQuery(document).ready(function($) {

$('#kusersearch').atwho({
at: "",
tpl: '<li data-value="${username}"><span class="glyphicon glyphicon-user"></span> ${username} <small>(${name})</small></li>',
displayTpl: '<li data-value="${name}"><span class="icon icon-user"></span> ${name} <small>(${name})</small></li>',

This comment has been minimized.

@810

810 Nov 11, 2016

Member

need to be glyphicon

This comment has been minimized.

@xillibit

xillibit Nov 11, 2016

Member

which glyphicon should need to use ?

This comment has been minimized.

@810

810 Nov 11, 2016

Member

glyphicon glyphicon-user

@xillibit xillibit force-pushed the xillibit:K5.0_bugs24 branch from aa4ec08 to b7774d7 Nov 13, 2016

@810 810 merged commit 38e8400 into Kunena:K5.0 Nov 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@xillibit xillibit deleted the xillibit:K5.0_bugs24 branch Feb 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment