Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give an access to the inbox count value #5002

Merged
merged 1 commit into from Nov 15, 2016
Merged

Give an access to the inbox count value #5002

merged 1 commit into from Nov 15, 2016

Conversation

@obsidev
Copy link
Contributor

@obsidev obsidev commented Nov 15, 2016

Pull Request for Improvement.

Summary of Changes

The login controller just provided the "inboxCount" which is a string but it can be useful to also have the number value.
Thanks to that it can be possible in the "login" layout widget, to display the counter in a small label just near the avatar icon (or as a stamp).
The users will then have a direct information of their inbox status without having to open their profile menu.

Testing Instructions

In the layout "widget/login/logout/default.php" is it then possible to add the code:

<?php if (!empty($this->pm_link) && $this->inboxCountValue > 0) : ?>
        <span class="inbox-counter"><span class="label label-info"><?php echo $this->inboxCountValue; ?></span></span>
<?php endif; ?>

Just before the display of the avatar image (and also add some CSS to improve the display).

The login controller just provided the "inboxCount" which is a string but it can be useful to also have the number value.
Thanks to that it can be possible in the "login" layout widget, to display the counter in a small label just near the avatar icon (or as a stamp).
The users will then have a direct information of their inbox status without having to open their profile menu.
@810 810 added 5.0 enhance labels Nov 15, 2016
@810 810 added this to the 5.0.4 milestone Nov 15, 2016
@810 810 merged commit c85691c into Kunena:K5.0 Nov 15, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
810 added a commit that referenced this pull request Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.