-
-
Notifications
You must be signed in to change notification settings - Fork 808
Fixed the wrong URL #5070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the wrong URL #5070
Conversation
i had changed this because suffix was breaking the preview. Did you also test it with suffix? |
I'm sorry, I'm not sure to have understood. What suffix? Could you explain further? |
The joomla url suffix, like .html We had a problem with showing the preview, with suffix turned on the joomla global configuration. |
Well, for sure there is a problem with old Joomla 1.6 - 2.5 websites updated to Joomla 3, since they have a statement in their .htaccess which is incompatible with some Kunena URLS, especially the upload: That being said, in my opinion, both the code before and after this patch work great regardless of SEF options, because in both cases it points to a non SEF URL. To conclude, I think that with this patch, the preview should work with every combination of SEF settings, but I haven't tried yet. |
|
@demis-palma thnx, i have also fixed rating and avatar gallery. |
The preview action while editing a post, points to a malformed URL (half SEF, half non-sef), which is not guaranteed to be parsed correctly by Joomla, and alerts some Web Application Firewall since the php file called (/forum/5-support/topic/index.php) does not exists on the filesystem (see below).
Given that the topic URL is http:// site.com/forum/5-support/topic/create.html
and the preview URL is relative index.php?option=com_kunena&view=topic&layout=edit&format=raw
then the actual preview URL will be /forum/5-support/topic/index.php?option=com_kunena&view=topic&layout=edit&format=raw which is wrong.
In addition, the value calculated for "kpreview_url" was never used.