New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized login links #5106

Merged
merged 2 commits into from Dec 19, 2016

Conversation

Projects
None yet
2 participants
@demis-palma
Contributor

demis-palma commented Dec 15, 2016

The option to hide right nav position introduced recently, #5021 causes that the login links in messages ("Please Log in or Create an account to join the conversation") could point to a non existing login module, so it's necessary to generalise them to use the system login component.

@demis-palma

This comment has been minimized.

Contributor

demis-palma commented Dec 15, 2016

In other words, if I disable the Kunena login module, all the login links still points to /forum/1-category/2-topic.html#klogin which does not exist.

@demis-palma

This comment has been minimized.

Contributor

demis-palma commented Dec 15, 2016

Improved to make the code compatible with sites without an existing login menu item.
Tested on both cases, each one in turn, with and without Joomla SEF.

@810

This comment has been minimized.

Member

810 commented Dec 15, 2016

thnx will check it later

@810 810 merged commit 82da0b2 into Kunena:K5.0 Dec 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@810 810 added 5.0 enhance labels Dec 19, 2016

@810 810 added this to the 5.0.5 milestone Dec 19, 2016

810 added a commit that referenced this pull request Dec 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment