New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending Social Sharing with Custom tag #5269

Merged
merged 1 commit into from Mar 27, 2017

Conversation

Projects
None yet
2 participants
@Ruud68
Contributor

Ruud68 commented Mar 24, 2017

Pull Request for New Feature

The implementation of jssocials sharing buttons works good, but a lot of websites have their own social sharing plugin.
This PR adds the possibiity to use 'whatever' social sharing plugin your website has and integrate it into Kunena to get a consistent look and feel all over your website.

Summary of Changes

Add crypsis(b3) configuration option to add Socials Sharing Custom Tag ( in template / features), added new layout widget

Testing Instructions

In Kunena template configuration > select crypsis(b3) > goto Featured tab and configure settings

Display Social Share (no / yes / Custom tag): Custom tag
Social Share Custom Tag: {jssocials} (as an example for the ochjssocials plugin)

When visiting a topic on the forum, the new social sharing buttons should appear and be exactly the same as for all other Joomla pages (where the jssocials plugin is used).

This can also be tested with other plugins and even be used for other functionality :)

For the Kunena forum this would fix the issue you see here: https://www.kunena.org/forum/76-Official-Announcements-and-News-about-Kunena/139657-kunena-5-0-6-released
in the blog the {jssocials} plugin is used with css plain. on the forum (crypsys) the css classic is used.
Now you see a combination of both on the kunena page.
When configuring the crypsis template to use custom tag {jssocials} this issue is fixed AND you are able to configure all {jssocial} settings in one place!

Please see me with any questions!

@810 810 added 5.0 feature labels Mar 27, 2017

@810 810 added this to the 5.0.7 milestone Mar 27, 2017

@810 810 merged commit 0b1661b into Kunena:K5.0 Mar 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Ruud68

This comment has been minimized.

Contributor

Ruud68 commented Mar 28, 2017

Top! Thanks for merging :)

810 added a commit that referenced this pull request Mar 30, 2017

Extending Social Sharing with Custom tag (#5269)
Add an optional extended description…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment