Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parent share div for customsharetag #5291

Merged
merged 1 commit into from Apr 5, 2017
Merged

Remove parent share div for customsharetag #5291

merged 1 commit into from Apr 5, 2017

Conversation

@Ruud68
Copy link
Contributor

@Ruud68 Ruud68 commented Apr 1, 2017

Pull Request for Issue # .
Just ran into this issue with a client site utilizing the new customsharetag and {jssocials}.

is not a Kunena div to identify the 'share position' but a jssocials div id to replace with the sharing buttons. Keeping this div id interferes with the jssocials script is this is added via a customsharetag :(

Summary of Changes

the widget layouts for customsocialshares are 'stripped' of the surrounding div share id

Testing Instructions

When using {jssocials} the correct sharing buttons should appear and not the default sharing buttons that are created by the jssocials script.

@810 810 merged commit e188e35 into Kunena:K5.0 Apr 5, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
810 added a commit that referenced this pull request Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants