New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message not visible on drag and drop #5288 #5297

Merged
merged 1 commit into from Apr 5, 2017

Conversation

Projects
None yet
3 participants
@xillibit
Member

xillibit commented Apr 4, 2017

Pull Request for Issue #5288.

Summary of Changes

Testing Instructions

@xillibit xillibit added the 5.0 label Apr 4, 2017

@sshcli

This comment has been minimized.

Member

sshcli commented Apr 4, 2017

I have tested now, and I can't see the difference

@810

This comment has been minimized.

Member

810 commented Apr 5, 2017

remove the fix, and add this to line 252
$('#kattach_form').show();

@xillibit

This comment has been minimized.

Member

xillibit commented Apr 5, 2017

If you do a drag&drop, it show the form, in this case it's work if the file size is above the limit set in confiuration, i will add the change suggested by jelle to make it working in all cases

@sshcli

This comment has been minimized.

Member

sshcli commented Apr 5, 2017

it works for me now.
but only when moving code to line 252

@xillibit xillibit force-pushed the xillibit:K5.0_bugs8 branch from 5205533 to 194d825 Apr 5, 2017

@xillibit

This comment has been minimized.

Member

xillibit commented Apr 5, 2017

Try now

@sshcli

This comment has been minimized.

Member

sshcli commented Apr 5, 2017

Test results = Success ✔

@810 810 merged commit 21a206a into Kunena:K5.0 Apr 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@810 810 added this to the 5.0.8 milestone Apr 5, 2017

@810 810 added the enhance label Apr 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment