Skip to content

Conversation

@xillibit
Copy link
Member

@xillibit xillibit commented Jul 3, 2017

Pull Request for Issue #5456.

Summary of Changes

Testing Instructions

@xillibit xillibit added this to the 5.0.11 milestone Jul 3, 2017
@mc-hovanskiy
Copy link

Please correct this way:
' google ' => array ( ' url ' => 'https://plus.google.com/+## VALUE ## ' , ' title ' => JText :: _ ( ' COM_KUNENA_MYPROFILE_GOOGLE ' ), ' nourl ' => ' 0 ' ),

' vk ' => array ( ' url ' => ' https://vk.com/## VALUE ## ' , ' title ' => JText :: _ ( ' COM_KUNENA_MYPROFILE_VK ' ), ' nourl ' => ' 0 ' ),

' telegram ' => array ( ' url ' => ' https://t.me/## VALUE ## ' , ' title ' => JText :: _ ( ' COM_KUNENA_MYPROFILE_TELEGRAM ' ), ' nourl ' => ' 0 ' ),

@mc-hovanskiy
Copy link

and Skype
' skype ' => array ( ' url ' => ' skype:## VALUE ## ' , ' title ' => JText :: _ ( ' COM_KUNENA_MYPROFILE_SKYPE ' ), ' nourl ' => ' 0 ' ),

@xillibit
Copy link
Member Author

xillibit commented Jul 4, 2017

Please correct this way:
' google ' => array ( ' url ' => 'https://plus.google.com/+## VALUE ## ' , ' title ' => JText :: _ ( ' COM_KUNENA_MYPROFILE_GOOGLE ' ), ' nourl ' => ' 0 ' ),

' vk ' => array ( ' url ' => ' https://vk.com/## VALUE ## ' , ' title ' => JText :: _ ( ' COM_KUNENA_MYPROFILE_VK ' ), ' nourl ' => ' 0 ' ),

' telegram ' => array ( ' url ' => ' https://t.me/## VALUE ## ' , ' title ' => JText :: _ ( ' COM_KUNENA_MYPROFILE_TELEGRAM ' ), ' nourl ' => ' 0 ' ),

and Skype
' skype ' => array ( ' url ' => ' skype:## VALUE ## ' , ' title ' => JText :: _ ( ' COM_KUNENA_MYPROFILE_SKYPE ' ), ' nourl ' => ' 0 ' ),

The issue by doing that is that we need to add an update tool to convert the existing info in the profile, else users will have some issues

@xillibit
Copy link
Member Author

I have updated it, no need to add an update tool

@810 810 merged commit 0901fe8 into Kunena:K5.0 Aug 15, 2017
810 added a commit that referenced this pull request Aug 15, 2017
@xillibit xillibit deleted the K5.0_bugs19 branch May 25, 2018 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants