Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google icon does not have a link #5456 #5468

Merged
merged 1 commit into from Aug 15, 2017
Merged

Google icon does not have a link #5456 #5468

merged 1 commit into from Aug 15, 2017

Conversation

@xillibit
Copy link
Member

@xillibit xillibit commented Jul 3, 2017

Pull Request for Issue #5456.

Summary of Changes

Testing Instructions

@xillibit xillibit added this to the 5.0.11 milestone Jul 3, 2017
@mc-hovanskiy
Copy link

@mc-hovanskiy mc-hovanskiy commented Jul 4, 2017

Please correct this way:
' google ' => array ( ' url ' => 'https://plus.google.com/+## VALUE ## ' , ' title ' => JText :: _ ( ' COM_KUNENA_MYPROFILE_GOOGLE ' ), ' nourl ' => ' 0 ' ),

' vk ' => array ( ' url ' => ' https://vk.com/## VALUE ## ' , ' title ' => JText :: _ ( ' COM_KUNENA_MYPROFILE_VK ' ), ' nourl ' => ' 0 ' ),

' telegram ' => array ( ' url ' => ' https://t.me/## VALUE ## ' , ' title ' => JText :: _ ( ' COM_KUNENA_MYPROFILE_TELEGRAM ' ), ' nourl ' => ' 0 ' ),

@mc-hovanskiy
Copy link

@mc-hovanskiy mc-hovanskiy commented Jul 4, 2017

and Skype
' skype ' => array ( ' url ' => ' skype:## VALUE ## ' , ' title ' => JText :: _ ( ' COM_KUNENA_MYPROFILE_SKYPE ' ), ' nourl ' => ' 0 ' ),

@xillibit
Copy link
Member Author

@xillibit xillibit commented Jul 4, 2017

Please correct this way:
' google ' => array ( ' url ' => 'https://plus.google.com/+## VALUE ## ' , ' title ' => JText :: _ ( ' COM_KUNENA_MYPROFILE_GOOGLE ' ), ' nourl ' => ' 0 ' ),

' vk ' => array ( ' url ' => ' https://vk.com/## VALUE ## ' , ' title ' => JText :: _ ( ' COM_KUNENA_MYPROFILE_VK ' ), ' nourl ' => ' 0 ' ),

' telegram ' => array ( ' url ' => ' https://t.me/## VALUE ## ' , ' title ' => JText :: _ ( ' COM_KUNENA_MYPROFILE_TELEGRAM ' ), ' nourl ' => ' 0 ' ),

and Skype
' skype ' => array ( ' url ' => ' skype:## VALUE ## ' , ' title ' => JText :: _ ( ' COM_KUNENA_MYPROFILE_SKYPE ' ), ' nourl ' => ' 0 ' ),

The issue by doing that is that we need to add an update tool to convert the existing info in the profile, else users will have some issues

@xillibit xillibit force-pushed the xillibit:K5.0_bugs19 branch from fabb83b to 97ab534 Aug 15, 2017
@xillibit
Copy link
Member Author

@xillibit xillibit commented Aug 15, 2017

I have updated it, no need to add an update tool

@810 810 merged commit 0901fe8 into Kunena:K5.0 Aug 15, 2017
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
810 added a commit that referenced this pull request Aug 15, 2017
@xillibit xillibit deleted the xillibit:K5.0_bugs19 branch May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants