New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When admin edit uers profile, let see him the tab to change avatar #5514

Merged
merged 1 commit into from Aug 22, 2017

Conversation

Projects
None yet
3 participants
@xillibit
Member

xillibit commented Aug 17, 2017

Pull Request for Issue # .

Summary of Changes

This change allow when go on profile on users on edit part, to see see the tabs : avatar and user details

Testing Instructions

By example on K5.1,, when i'am connected as admin and i open the profile of user nammed jack, without this change i can see only this :

ff

@xillibit xillibit added 5.0 bug labels Aug 17, 2017

@xillibit xillibit added this to the 5.0.11 milestone Aug 17, 2017

@rich20

This comment has been minimized.

Member

rich20 commented Aug 17, 2017

  • The tab is now available, but inactive (it switches not to the avatar options)
@810

This comment has been minimized.

Member

810 commented Aug 18, 2017

We have this already on K5.1, this should be a new feature

@xillibit

This comment has been minimized.

Member

xillibit commented Aug 18, 2017

I have just checked on K5.1, it's not present, i had added some descriptions in the detail of the pull request

@rich20

This comment has been minimized.

Member

rich20 commented Aug 18, 2017

I have just checked on K5.1, it's not present, i had added some descriptions in the detail of the pull request

We have this already on K5.1, this should be a new feature

Confirmed, with K5.1 it works without this patch. But with this patch the tab is inactive also in K5.1 and it switches not to the avatar options..

@810

This comment has been minimized.

Member

810 commented Aug 18, 2017

this is the commit:
7dc904b

@xillibit xillibit force-pushed the xillibit:K5.0_bugs23 branch from 77996b7 to 39e63f6 Aug 19, 2017

@xillibit

This comment has been minimized.

Member

xillibit commented Aug 19, 2017

I have updated it if you siwth on avatar tab you can the settings for avatar and it's the same for tab user details

@rich20

This comment has been minimized.

Member

rich20 commented Aug 19, 2017

@xillibit is this branche up do date? It lacks some options for user edit.
Now it lacks the edit option for Global moderators in the frontend (previously it was available)
It shows no avatar in the Avatar options (Fronttend)
It lacks the new user edit options in the backend

@xillibit

This comment has been minimized.

Member

xillibit commented Aug 19, 2017

I have just checked the branch is up-do-date

@rich20

This comment has been minimized.

Member

rich20 commented Aug 19, 2017

I have just checked the branch is up-do-date

Thank you!

  • It lacks the edit option for Global moderators in the frontend (previously it was available)
  • It shows no avatar in the profile edit options (also not in the own profile)
@xillibit

This comment has been minimized.

Member

xillibit commented Aug 19, 2017

I don't understand the two point

@rich20

This comment has been minimized.

Member

rich20 commented Aug 19, 2017

  1. A global moderator can't edit another user profile (unless he ban a user)
  2. You see not the avatar (see image)

bildschirmfoto von 2017-08-19 18-13-17

@rich20

This comment has been minimized.

Member

rich20 commented Aug 19, 2017

I'm sorry, please forget point two. I think that I need vacation. 🤒
But point 1 should be available also for Global Moderators

@xillibit xillibit force-pushed the xillibit:K5.0_bugs23 branch from 39e63f6 to cd16de4 Aug 19, 2017

@xillibit

This comment has been minimized.

Member

xillibit commented Aug 19, 2017

A global moderator can't edit another user profile (unless he ban a user)

I had changed that, the fix already exist into K5.1

@rich20

This comment has been minimized.

Member

rich20 commented Aug 19, 2017

I had changed that, the fix already exist into K5.1

Yes, I had seen, that this option already has worked. Therefore I was confused. Sorry again!

  • The global Moderator get now a message when he click on Edit button in other user profile

You have been banned! You do not have access to this function.

@xillibit xillibit force-pushed the xillibit:K5.0_bugs23 branch from cd16de4 to f45aa4f Aug 19, 2017

@xillibit

This comment has been minimized.

Member

xillibit commented Aug 19, 2017

Should be ok now

@rich20

This comment has been minimized.

Member

rich20 commented Aug 19, 2017

  • Success

@810 810 merged commit 1f81edd into Kunena:K5.0 Aug 22, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

810 added a commit to 810/Kunena-Forum that referenced this pull request Sep 13, 2017

810 added a commit that referenced this pull request Sep 13, 2017

@xillibit xillibit deleted the xillibit:K5.0_bugs23 branch Sep 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment