Skip to content

Hide subscribe checkbox on edit (Only Mod/Admin) #5663#5664

Merged
810 merged 1 commit intoKunena:K5.0from
xillibit:K5.0_bugs33
Dec 9, 2017
Merged

Hide subscribe checkbox on edit (Only Mod/Admin) #5663#5664
810 merged 1 commit intoKunena:K5.0from
xillibit:K5.0_bugs33

Conversation

@xillibit
Copy link
Member

@xillibit xillibit commented Dec 2, 2017

Pull Request for Issue #5663.

Summary of Changes

Testing Instructions

@xillibit xillibit added the 5.0 label Dec 2, 2017
@xillibit xillibit added this to the 5.0.13 milestone Dec 2, 2017
@sshcli
Copy link
Member

sshcli commented Dec 2, 2017

In my test, this PR works ok.
It hides the subscribe checkbox only when admin or global mod is editing someone else topic.

However, I have updated the issue, because I found that the subscribe checkbox doesn't work on edit at all, it's not only admin/mod, it doesn't work for anyone.

So, the fix should be hide it for everyone on edit view.

Sorry for any inconvenience caused

@xillibit
Copy link
Member Author

xillibit commented Dec 9, 2017

Subscribe checkbox doesn't appear on edit

@810 810 merged commit c7766dd into Kunena:K5.0 Dec 9, 2017
@xillibit xillibit deleted the K5.0_bugs33 branch May 25, 2018 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants