Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide subscribe checkbox on edit (Only Mod/Admin) #5663 #5664

Merged
merged 1 commit into from Dec 9, 2017

Conversation

@xillibit
Copy link
Member

@xillibit xillibit commented Dec 2, 2017

Pull Request for Issue #5663.

Summary of Changes

Testing Instructions

@xillibit xillibit added the 5.0 label Dec 2, 2017
@xillibit xillibit added this to the 5.0.13 milestone Dec 2, 2017
@xillibit xillibit force-pushed the xillibit:K5.0_bugs33 branch from 4e367d0 to d576cc6 Dec 2, 2017
@sshcli
Copy link
Member

@sshcli sshcli commented Dec 2, 2017

In my test, this PR works ok.
It hides the subscribe checkbox only when admin or global mod is editing someone else topic.

However, I have updated the issue, because I found that the subscribe checkbox doesn't work on edit at all, it's not only admin/mod, it doesn't work for anyone.

So, the fix should be hide it for everyone on edit view.

Sorry for any inconvenience caused

@xillibit
Copy link
Member Author

@xillibit xillibit commented Dec 9, 2017

Subscribe checkbox doesn't appear on edit

@810 810 merged commit c7766dd into Kunena:K5.0 Dec 9, 2017
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
810 added a commit that referenced this pull request Dec 9, 2017
@xillibit xillibit deleted the xillibit:K5.0_bugs33 branch May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants