Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subscriptions when perm block from site #5945 #6015

Merged
merged 6 commits into from Jul 1, 2018
Merged

Remove subscriptions when perm block from site #5945 #6015

merged 6 commits into from Jul 1, 2018

Conversation

@810
Copy link
Member

@810 810 commented Jun 29, 2018

@rich20 @sshcli please test if all subscriptions are still working.

#5945

If joomla user is blocked, you should not get any email anymore.

@810 810 added this to the 5.1.2 milestone Jun 29, 2018
@810 810 requested review from rich20 and sshcli Jun 29, 2018
810 added 3 commits Jun 29, 2018
Copy link
Member

@sshcli sshcli left a comment

Test Results = Fail

What is good / working?
After apply patch, the blocked user does not receive email notifications

What is wrong/not working?
You get these errors when quick reply the topic:

0 Unsupported operand types
PHP Notice:  Undefined variable: userids in /home/username/libraries/kunena/access.php on line 1037
PHP Warning:  array_flip() expects parameter 1 to be array, null given in /home/username/libraries/kunena/access.php on line 877
PHP Warning:  array_intersect_key(): Argument #2 is not an array in /home/username/libraries/kunena/access.php on line 877
@810
Copy link
Member Author

@810 810 commented Jun 30, 2018

@sshcli please try again, should now work

@sshcli
Copy link
Member

@sshcli sshcli commented Jul 1, 2018

Test Results = ✔️ Pass / Success / OK

@810 810 merged commit f887642 into K5.1 Jul 1, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@810 810 deleted the emailsub branch Jul 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants