New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fix empty action dropdown #6038

Merged
merged 2 commits into from Jul 12, 2018

Conversation

Projects
None yet
3 participants
@WooDzu
Contributor

WooDzu commented Jul 12, 2018

Describe the bug
Empty dropdown appears for unprivileged users.

To Reproduce
Steps to reproduce the behavior:

  1. Use regular/unprivileged account
  2. Go to list of topics
  3. "Select Action" dropdown is empty and has no use

Expected behavior
The dropdown should be hidden.

Actual result
It has only "- Chose action -" option

Screenshots
chooseaction

System information (please complete the following information)

Joomla version: 3.8
Kunena version: 5.1.1
Php version: 7

WooDzu added some commits Jul 12, 2018

@810

This comment has been minimized.

Member

810 commented Jul 12, 2018

does the count also work on Php 5.x and 7.x .

@WooDzu

This comment has been minimized.

Contributor

WooDzu commented Jul 12, 2018

Yes, count() works on 5 and 7, in fact it was added long tim before 5.
I've done an extra test on 5.6.34 to double-check.

FWIW this could also be fixed in the template but I think it's good to fix it at the source as other templates have same issue (eg Kvivid)

@rich20

This comment has been minimized.

Member

rich20 commented Jul 12, 2018

  • Yes, it works as it should.

Tested with php 5.5.38 and php 7.2.1 as well Joomla 3.8.11-dev and Kunena 5.1.2-DEV

@810 810 added enhance 5.1 labels Jul 12, 2018

@810 810 added this to the 5.1.2 milestone Jul 12, 2018

@810 810 merged commit 0c779fd into Kunena:K5.1 Jul 12, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@WooDzu WooDzu deleted the WooDzu:patch-1 branch Jul 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment