Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore internal links in checkMaxLinks() #6039 #6057

Merged
merged 1 commit into from Jul 24, 2018
Merged

Ignore internal links in checkMaxLinks() #6039 #6057

merged 1 commit into from Jul 24, 2018

Conversation

@WooDzu
Copy link
Contributor

@WooDzu WooDzu commented Jul 24, 2018

Pull Request for Issue #6039
Slightly different approach than originally proposed.

Summary of Changes

Removes internal links from checkMaxLinks() checks which will covers attachments, auto-linked internal images and all other goods added by 3rd party plugins.

Testing Instructions

  • As described in ticket #6039
  • Additionally non-image attachements should not trigger the error
  • Any other internal links should not trigger the error. Examples of internal links
    ** /home
    ** /index.php/home
    ** http://[LIVE_SITE]/home
@810 810 added this to the 5.1.3 milestone Jul 24, 2018
@810 810 merged commit c46a89f into Kunena:K5.1 Jul 24, 2018
1 check failed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants