New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reviewCount beside stars #6058 #6062

Merged
merged 1 commit into from Jul 27, 2018

Conversation

Projects
None yet
3 participants
@xillibit
Member

xillibit commented Jul 27, 2018

Pull Request for Issue #6058 .

Summary of Changes

Testing Instructions

@xillibit xillibit added this to the 5.1.3 milestone Jul 27, 2018

@xillibit xillibit force-pushed the xillibit:K5.1_bugs28 branch from c23479c to 67e49af Jul 27, 2018

@sshcli

This comment has been minimized.

Member

sshcli commented Jul 27, 2018

Test results = ✔️Pass

Basically, the function works ok.

Two minor observations to consider:

  1. The number needs additional style (Maybe in a second PR)
    it could be something similar to Google reviews:
    format

  2. Banned users are able to rate a topic, even when they get the error message saying they are not allowed (Without this fix banned users can rate the topic without any warning)
    Maybe this is a different and unrelated bug. I will create an issue for it after merge this PR.

@810 810 merged commit 088864e into Kunena:K5.1 Jul 27, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@xillibit xillibit deleted the xillibit:K5.1_bugs28 branch Aug 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment