Upgrade Fancybox to 3.4.0 #6101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Changes
Data attributes data-trigger and data-index are renamed to data-fancybox-trigger and data-fancybox-index to avoid conflicts with Bootstrap
videoFormat option is replaced by new video option ( video : {tpl : "..", format : "", autoStart : true}) and it is now possible to change html5 video template and to enable/disable autoplay
autoFocus option now has default value true
Youtube videos now uses youtube-nocookie.com domain
Redesigned SVG icons
New
New option closeExisting can be used to close any previously opened instances before opening new one
New callback onSlideShowChange is triggered when slideshow starts/stops
Improvements
This release is mostly focused on bug fixes. There are some performance improvements; improved user experience while using tab for navigating the page