Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module position in custom content #6113

Merged
merged 3 commits into from Sep 16, 2018
Merged

Add module position in custom content #6113

merged 3 commits into from Sep 16, 2018

Conversation

@sshcli
Copy link
Member

@sshcli sshcli commented Sep 15, 2018

Summary of Changes

bad
good

@sshcli
Copy link
Member Author

@sshcli sshcli commented Sep 15, 2018

There are some limitations while inserting a module inside a joomla article and then making the bbcode reference from the custom content menu [article]articleid[/article]

This PR is for enable the option to insert modules straight in the custom content menu (Without Joomla articles)

@rich20
Copy link
Member

@rich20 rich20 commented Sep 15, 2018

Is the double cc on the word "content" wanted or a typo?

@sshcli
Copy link
Member Author

@sshcli sshcli commented Sep 15, 2018

Is the double cc on the word "content" wanted or a typo?

Wanted.
The first C is the short key for custom

Of course this can be changed if cause confusions, I can use the long phrase.
Just tell me, and I will change it right away.

@rich20
Copy link
Member

@rich20 rich20 commented Sep 15, 2018

Yes, cconent is logical, but gives the impression of a typo. But it needs not a long phrase. Maybe it would enough kunena_c_content_top/bottom

@810
Copy link
Member

@810 810 commented Sep 15, 2018

please change to kunena_custom_top and kunena_custom_bottom

@rich20
Copy link
Member

@rich20 rich20 commented Sep 15, 2018

please change to 'kunena_custom_top' and 'custom_custom_bottom'

I think, you meant 'kunena_custom_top' and 'kunena_custom_bottom'

@sshcli
Copy link
Member Author

@sshcli sshcli commented Sep 15, 2018

Done

@810 810 merged commit f88573b into Kunena:K5.1 Sep 16, 2018
1 check failed
@sshcli sshcli deleted the PR120 branch May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants